Remove audio capture stats that have moved to MediaStreamTrack's stats #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR removes all the audio capture stats from WebRTC getStats() since we've moved them (or their equivalents) to MediaStreamTrack @jan-ivar (We still have the lack-of-consensus "playout-stats", but that's a whole separate dictionary) |
jan-ivar
approved these changes
Dec 14, 2023
|
Not implemented across the board according to https://wpt.fyi/results/webrtc-stats/supported-stats.https.html?label=experimental&label=master&aligned |
webkit-commit-queue
pushed a commit
to Ahmad-S792/WebKit
that referenced
this pull request
Jun 28, 2024
https://bugs.webkit.org/show_bug.cgi?id=275832 Reviewed by Darin Adler and Youenn Fablet. This patch aligns WebKit with web specification [1]: [1] https://w3c.github.io/webrtc-stats/#dom-rtcaudiosourcestats It aligns by removing dropped metrics [2]: [2] w3c/webrtc-stats#773 * Source/WebCore/Modules/mediastream/RTCStatsReport.h: * Source/WebCore/Modules/mediastream/RTCStatsReport.idl: Canonical link: https://commits.webkit.org/280461@main
mnutt
pushed a commit
to movableink/webkit
that referenced
this pull request
Aug 27, 2024
https://bugs.webkit.org/show_bug.cgi?id=275832 Reviewed by Darin Adler and Youenn Fablet. This patch aligns WebKit with web specification [1]: [1] https://w3c.github.io/webrtc-stats/#dom-rtcaudiosourcestats It aligns by removing dropped metrics [2]: [2] w3c/webrtc-stats#773 * Source/WebCore/Modules/mediastream/RTCStatsReport.h: * Source/WebCore/Modules/mediastream/RTCStatsReport.idl: Canonical link: https://commits.webkit.org/280461@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #741
The latency and dropped metrics are now part of track.stats
Preview | Diff