-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose in VideoFrameMetadata some fields from VideoFrameCallbackMetadata #601
Comments
These sound fine to me, but @aboba points out that https://wicg.github.io/video-rvfc/ may not meet the registry requirements yet. I know at TPAC there was some talk of moving rVFC into the HTML spec. Do we still want to do that? |
I think the idea would be to write a registry entry that would define these values without referencing rvfc. Instead, it would reference webrtc-pc and/or media capture-main. |
Yes, I was still planning on moving rVFC to the HTML spec. I haven't found the time to do so yet. Embedding the spec into the HTML spec is more work than just referencing it. Previous (closed) PR tracking this work: |
I agree, adding this into HTML makes sense. |
The RVFC metadata items seem quite useful to me, but they also raise some questions for the behavior of other APIs:
Without an explicit change to the WebCodecs API, I'm assuming that the answer to questions 2 and 3 is "no". But what I'd really like to be able to do is to trace performance through each stage of the receive and send pipeline. |
It depends on MediaStreamTrack's source. If source is getUserMedia, yes.
EncodedVideoChunk has no metadata so I would think that it would not be carried automatically.
My understanding is that the decoder will not have that data so will not set it. |
We now have a proposal to add some timing information to the Would it make sense to define a metadata registry for |
Is it possible to make progress with this? |
Why can't we use regular VideoFrame.timestamp for capture time when frames are coming from a capture device. |
@guidou reached out to me last Friday about surfacing capture timestamps, proposing The |
We should probably discuss it in the next WG meeting. |
We can do that. However, when writing a VideoFrame to a VideoTrackGenerator it is useful to know that the timestamp is a capture timestamp (or alternatively, that the VideoFrame should be treated as a frame coming from a capturer) since the downstream sinks (e.g., a Peer Connection) may treat the frame differently from non-capturer frames. Currently it is not possible to make this distinction, even if the timestamp of capture VideoFrames is the capture timestamp. |
We have use cases for VideoFrame that don't involve encoders or decoders (at least WebCodec ones) that would benefit from this metadata. These use mediacapture-transform. |
Seems that when we have metadata on VideoFrame and metadata on RtcEncodedVideoFrame, and we're not looking at an option to make WebCodecs produce/consume RTCEncodedVideoFrame, there's an argument to make that we should be adding metadata to EncodedVideoChunk too, so that it can be carried throughout the ecosystem. |
Yes, this was requested in the past, but I don't remember by who or for what. But it would be useful for sure. I think it was someone working in the cinema industry, but I could be completely misremembering. |
@alvestrand @padenot Here are the Issues relating to |
Related PR: #813 Once this PR is merged, can we close this issue? @Djuffin @youennf @guidou @alvestrand What are your thoughts? |
Yes, I think when we merge PR: #813 we can close this one. |
It seems useful to expose some fields in VideoFrameMetadata like:
This could be added as an entry in VideoFrameMetadata registry.
The text was updated successfully, but these errors were encountered: