-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map options member identifiers and credential types: public-key vs publicKey #181
Map options member identifiers and credential types: public-key vs publicKey #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this long standing issue! I like the registry mapping.
You mixed in some editorial changes in this PR. Can you update the PR description to point that out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending Jeffrey's comments
Co-authored-by: Jeffrey Yasskin <[email protected]>
Co-authored-by: Jeffrey Yasskin <[email protected]>
Co-authored-by: Jeffrey Yasskin <[email protected]>
) Co-authored-by: Jeffrey Yasskin <[email protected]>
Use the registry to find interface objects for a CredentalOptions: Merge branch 'jeffh-fix-147-options-member-name-and-cred-type' of https://github.com/w3c/webappsec-credential-management into jeffh-fix-147-options-member-name-and-cred-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM aside from one nit.
Please see issue #147 and w3c/webauthn#1004 for full context.
The summary is that this PR introduces a registry mapping credential types to options member identifiers, and updates the magical relevant credential interface objects algorithm to use the latter registry.
This is the "...define a mapping from dictionary member names to
[[type]]
values or vice versa." solution identified by @bzbarsky in w3c/webauthn#1004 (comment). @jyasskin had also independently suggested using a registry for this mapping.Additionally, this PR contains some modest editorial updates/changes (that seem appropriate to make in conjunction with this PR's primary mission of mapping cred types to options member identifiers):
1.
numbering for all steps in algs that I modified.fixes #147
Preview | Diff