Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isn't this test suite supposed to test JOSE/COSE formatted credentials? #15

Open
antonio-ivanovski opened this issue Nov 12, 2024 · 0 comments

Comments

@antonio-ivanovski
Copy link

antonio-ivanovski commented Nov 12, 2024

From reading the spec at https://www.w3.org/TR/vc-jose-cose, it aims at securing/formatting the VC/VP and formatting as JWT or COSE. Looking at the repository initial expectation was that these inputs (JWT/COSE) were being generated from the testcases directory. But going deeper and adding an implementation, I can see that the input is from the ./tests/input directory, containing VCs in JSON format.

  1. Am I misunderstanding this specification?
  2. Should the implementation also provide implementation for issuance of the input credentials (example: issue the test/input/valid-credential.json as JWT credential)?
  3. Is this still early test-suite and it is not ready to be implemented on-top of?
  4. Why is there config with check to run? Some verifiers don't have the notion of such fine-grained checks.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant