-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server-timing names #561
Comments
@SergeyKanzhelev : I like your proposal because it reframes it from the point of view of the server operation: its id, which trace it is part of, (optional) its sampling info, and its name/duration (in the future). So overall, I feel this fits better with having this info in server-timing. CC: @dyladan @basti1302 @jcopi what do you think? |
Also, in the context of this discussion, should we think about its implications for trace state response as well? For example, is that a separate metric or can that information be folded into the above, etc.? |
good question. I would think |
I feel there is a tradeoff between: I agree that the metric name Same goes for the equivalent of the request header For some reason I cannot put my finger on, I feel a bit more strongly about this for How do you folks feel about introducing the new name |
+1 to reuse the names |
Following up on #560
The possible alternative for naming would be:
instead of:
use
Benefits:
The text was updated successfully, but these errors were encountered: