Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let MediaMetadata#artwork return the same value (unless set to a new value) #183

Open
foolip opened this issue Feb 13, 2017 · 2 comments
Open

Comments

@foolip
Copy link
Member

foolip commented Feb 13, 2017

https://wicg.github.io/mediasession/#dom-mediametadata-artwork

The definition of the getter is to return a new array on every access. While Web IDL doesn't disallow this, avoiding this is the reason that sequence<T> is no longer allowed as an attribute type.

Rather than returning a new array each time, the setter could set an internal slot that is used in the getter. This is almost how it's implemented in Blink, except that a new frozen array is created.

@youennf
Copy link
Contributor

youennf commented Mar 6, 2023

I am not sure what we should do here. Implementations probably follow the spec
We anyway have an issue here since setting the attribute will not store the same object.
Maybe we should add methods instead but this seems late here.

@youennf
Copy link
Contributor

youennf commented Oct 4, 2024

Fixed by #343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants