Identify the list of allowed required constraints for getUserMedia #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jan-ivar @alvestrand What are your thoughts? |
henbos
approved these changes
Sep 17, 2020
henbos
reviewed
Sep 17, 2020
alvestrand
reviewed
Sep 17, 2020
|
Editors can integrate with comments addressed |
youennf
force-pushed
the
filter-required-constraints-for-getUserMedia
branch
from
ac34dde
to
b79f978
Compare
youennf
force-pushed
the
filter-required-constraints-for-getUserMedia
branch
from
b79f978
to
a084f38
Compare
Co-authored-by: Dominique Hazael-Massieux <[email protected]>
jan-ivar
requested changes
Sep 24, 2020
jan-ivar
reviewed
Sep 24, 2020
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 25, 2020
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 25, 2020
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 26, 2020
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 28, 2020
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 28, 2020
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 28, 2020
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 28, 2020
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Eero Häkkinen <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#811242}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 28, 2020
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Eero Häkkinen <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#811242}
pull bot
pushed a commit
to Mu-L/chromium
that referenced
this pull request
Sep 28, 2020
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Eero Häkkinen <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#811242}
Fix required link and terminology Co-authored-by: Jan-Ivar Bruaroey <[email protected]>
|
Are we good merging the PR? |
jan-ivar
approved these changes
Sep 29, 2020
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 3, 2020
…basic getUserMedia constraints, a=testonly
Automatic update from web-platform-tests
[PTZ] Deny mandatory PTZ constraints in basic getUserMedia constraints
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Eero Häkkinen <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#811242}
--
wpt-commits: dcb7fbd8b1c1223fcc72819cf1c66ac2c03b04c8
wpt-pr: 25785
ziransun
pushed a commit
to ziransun/wpt
that referenced
this pull request
Oct 6, 2020
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Eero Häkkinen <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#811242}
ambroff
pushed a commit
to ambroff/gecko
that referenced
this pull request
Nov 4, 2020
…basic getUserMedia constraints, a=testonly
Automatic update from web-platform-tests
[PTZ] Deny mandatory PTZ constraints in basic getUserMedia constraints
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Eero Häkkinen <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#811242}
--
wpt-commits: dcb7fbd8b1c1223fcc72819cf1c66ac2c03b04c8
wpt-pr: 25785
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Eero Häkkinen <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#811242}
GitOrigin-RevId: e3d45995537f476c48728aac5c62da3ac8fbd133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case an unallowed required constraint is given to getUserMedia, skip it.
This would help w3c/mediacapture-image#229.