feat[venom]: memory write merging #4341
Open
+560
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking very nice |
HodanPlodky
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4341 +/- ##
==========================================
- Coverage 91.31% 88.52% -2.79%
==========================================
Files 113 114 +1
Lines 16061 16238 +177
Branches 2703 2742 +39
==========================================
- Hits 14666 14375 -291
- Misses 964 1334 +370
- Partials 431 529 +98 ☔ View full report in Codecov by Sentry. |
change the signature to dst, src, length as it mirrors the opcodes
harkal
reviewed
Nov 26, 2024
vyper/venom/passes/memmerging.py
Outdated
| return a < b | ||
|
|
||
| def overlap(self, other: "_Interval") -> bool: | ||
| a = max(self.src_start, other.src_end) |
There was a problem hiding this comment.
Suggested change
| a = max(self.src_start, other.src_end) | |
| a = max(self.src_start, other.src_start) |
harkal
reviewed
Nov 28, 2024
vyper/venom/passes/memmerging.py
Outdated
| intervals.clear() | ||
|
|
||
| def _add_interval( | ||
| self, intervals: list[_Interval], new_inter: _Interval, ok_dst_overlap: bool = False |
There was a problem hiding this comment.
Maybe use a better name for ok_dst_overlap? Something like allow_dst_overlap_src would be more self explanatory. I would pair that with changing the dst_overlap to dst_overlaps_src()
harkal
reviewed
Nov 28, 2024
vyper/venom/passes/memmerging.py
Outdated
| intervals.insert(index, new_inter) | ||
| if index > 0: | ||
| if intervals[index - 1].overlap(new_inter): | ||
| return False |
There was a problem hiding this comment.
Shouldn't we be removing the interval we just added here? Or do the insert after the checks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Reimplementation of methods from original pipeline optimizer into the venom pipeline, that handled merging of the multiple memory operations that writes into the continuous chuck of the memory into one instruction that does in batch.
How I did it
Created new pass for this purpose
How to verify it
I have written new tests
Commit message
feat[venom]: venom pipeline memory coalescing
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture