Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect transient storage codegen for extract32() and slice() #3801

Closed
charles-cooper opened this issue Feb 22, 2024 · 2 comments
Closed

incorrect transient storage codegen for extract32() and slice() #3801

charles-cooper opened this issue Feb 22, 2024 · 2 comments
Labels
bug - codegen priority - HIGH
Milestone
v0.4.0

Comments

@charles-cooper
Copy link
Member

charles-cooper commented Feb 22, 2024 •
edited
Loading

Version Information

  • vyper Version (output of vyper --version): 0.3.10

What's your issue about?

extract32() and slice() builtins hardcode checks for STORAGE, they should use the location.word_addressable check instead.

thanks to @trocher for reporting
@charles-cooper charles-cooper added this to the v0.4.0 milestone Feb 22, 2024
@charles-cooper charles-cooper pinned this issue Mar 14, 2024
@cyberthirst cyberthirst mentioned this issue Mar 19, 2024
Merged
@charles-cooper
Copy link
Member Author

fixed in #3874

@mozz30-tech

This comment was marked as abuse.

Sign in to view
@mozz30-tech mozz30-tech mentioned this issue May 23, 2024
Closed
@charles-cooper charles-cooper unpinned this issue Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug - codegen priority - HIGH
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
2 participants
@charles-cooper @mozz30-tech