Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Podman API 5.0.0 support #169

Open
dvzrv opened this issue Mar 31, 2024 · 4 comments · May be fixed by #171
Open

Podman API 5.0.0 support #169

dvzrv opened this issue Mar 31, 2024 · 4 comments · May be fixed by #171
Labels
C-bug Category: issue or a bug

Comments

@dvzrv
Copy link

dvzrv commented Mar 31, 2024

Hi! 👋

I've started using the podman-api crate and found it to be incredibly useful.
Unfortunately it stopped working with podman 5.0.0 and looking at the script to update the generated podman-api-stubs, I noticed that the script is currently not working anymore, as the upstream for the swagger generator is gone:

podman-api-rs/podman-api-stubs/build.sh

Line 9 in f35e6f9

RUSTGEN="https://git.wkepka.dev/wojtek/swagger-rustgen.git"

@vv9k would you be able to make that project available again? Maybe it would be more fail proof if this was hosted on github as well.

  • Crate version: 0.10.0
  • OS: Arch Linux
  • Output of running podman version on the command line:
Client:       Podman Engine
Version:      5.0.0
API Version:  5.0.0
Go Version:   go1.22.1
Git Commit:   e71ec6f1d94d2d97fb3afe08aae0d8adaf8bddf0-dirty
Built:        Thu Mar 21 23:30:17 2024
OS/Arch:      linux/amd64
@dvzrv dvzrv added the C-bug Category: issue or a bug label Mar 31, 2024
@dvzrv
Copy link
Author

dvzrv commented Apr 1, 2024

As a quick follow-up and note to anyone potentially interested in this topic:

The crate for generating the stubs in question is also available on github: https://github.com/vv9k/swagger-rustgen
The code in that repository seemingly does not work for generating stubs for version 5.0.0 and emits many errors for the current version (4.5.1) as well.

As the author (also of this crate) has not been active for eight months I am not entirely sure how long it will take for things to be upgraded for podman 5 support.

I have therefore also reached out to podman upstream for the possibility to auto-generate a client-side integration based on openapi-generator, which may serve as a more standardized way of integrating with Podman's API in the future.

@wez
Copy link

wez commented Apr 22, 2024

I have therefore also reached out to podman upstream for the possibility to auto-generate a client-side integration based on openapi-generator, which may serve as a more standardized way of integrating with Podman's API in the future.

@dvzrv: is there a link to that discussion or an update on how that's going?

@woodsb02 woodsb02 mentioned this issue Apr 25, 2024
Closed
@janst97 janst97 linked a pull request May 21, 2024 that will close this issue
Draft
@janst97
Copy link

janst97 commented May 21, 2024

I opened a PR to address this issue. Test cases succeed and my private projects work with the changes. However, I did not check specifically for API changes/updates to Podman v5, so I suspect that some things might be broken. Feel free to fork or improve the PR.

swagger-rustgen works with swagger definitions for podman 5.0.3, however I can confirm that it was broken for 5.0.0 and 5.0.1.

I'd also be interested in a long term alternative to this project, given its current inactivity.

@dvzrv
Copy link
Author

dvzrv commented May 22, 2024

I have therefore also reached out to podman upstream for the possibility to auto-generate a client-side integration based on openapi-generator, which may serve as a more standardized way of integrating with Podman's API in the future.

@dvzrv: is there a link to that discussion or an update on how that's going?

I have reached out to the community via Matrix but was then also asked to send a mail to their mailing list.
Have not yet done that, due to -ETOOMANYPROJECTS.

Meanwhile I have moved to rustainers for my test setup :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: issue or a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Draft] Update crate to work with Podman 5 API janst97/podman-api-rs
3 participants
@wez @dvzrv @janst97