Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Managed Kafka #487

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Support Managed Kafka #487

merged 5 commits into from
Oct 31, 2024

Conversation

christhemorse
Copy link
Contributor

Description

This PR adds support for Kafka subscriptions to our broader Vultr Managed Database endpoints. It should handle all required structural changes as well as new endpoints and advanced configuration options.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@christhemorse christhemorse added the enhancement New feature or request label Oct 30, 2024
@christhemorse christhemorse self-assigned this Oct 30, 2024
@github-actions GitHub Actions
Copy link

Unit Tests and Coverage

Show Output 
	github.com/vultr/vultr-cli/v3		coverage: 0.0% of statements

Pusher: @christhemorse, Action: pull_request_target

optik-aper
optik-aper previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@github-actions GitHub Actions
Copy link

Unit Tests and Coverage

Show Output 
	github.com/vultr/vultr-cli/v3		coverage: 0.0% of statements

Pusher: @christhemorse, Action: pull_request_target

@optik-aper optik-aper self-requested a review October 31, 2024 12:45
optik-aper
optik-aper approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@optik-aper optik-aper merged commit 88e7c03 into vultr:master Oct 31, 2024
4 checks passed
@optik-aper optik-aper mentioned this pull request Oct 31, 2024
Merged
3 tasks
@christhemorse christhemorse deleted the support-managed-kafka branch October 31, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper optik-aper approved these changes

Assignees

@christhemorse christhemorse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christhemorse @optik-aper