Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-slider incorrectly reports ticks as no-deprecated-props #69

Closed
MaximeGrimler opened this issue Jul 10, 2023 · 3 comments
Closed

v-slider incorrectly reports ticks as no-deprecated-props #69

MaximeGrimler opened this issue Jul 10, 2023 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@MaximeGrimler
Copy link

Hello,

According to the upgrade guide ticks has been renamed to show-ticks and tick-labels to ticks (https://vuetifyjs.com/en/getting-started/upgrade-guide/#v-slider-v-range-slider)

Nevertheless when using ticks I think he doesn't understand that we want to use the new prop (which replace tick-labels) but the old one as he always report an error on it
image

Is there any way to fix it?

Thanks!

@KaelWD
Copy link
Member

KaelWD commented Jul 10, 2023

eslint runs rules multiple times, if we autofix this then tick-labels will also be replaced with show-ticks

@MaximeGrimler
Copy link
Author

Maybe not autofixing it but for example if ticks is a boolean or "always" (type of show-ticks which had been deprecated) then throw an error ? Else consider we use the new notation (which is the old one from tick-labels) and don't throw any error.

Because currently I'm forced to deactivate the rule no-deprecated-props for that component as it looks like a circular error

@KaelWD
Copy link
Member

KaelWD commented Jul 10, 2023

if ticks is a boolean or "always" (type of show-ticks which had been deprecated) then throw an error

We don't know what labels is. I'm going to count this as basically the same as #59

@KaelWD KaelWD closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
@KaelWD KaelWD added the duplicate This issue or pull request already exists label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants