Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Module Reload #136

Open
shaun-sweet opened this issue Dec 17, 2017 · 6 comments
Open

Hot Module Reload #136

shaun-sweet opened this issue Dec 17, 2017 · 6 comments

Comments

@shaun-sweet
Copy link

If you run vue init vuejs-templates/pwa test to clone a new template then run it after installing all the dependencies, you'll notice HMR is not HMR. It is doing a hard refresh.

@LinusBorg
Copy link
Contributor

LinusBorg commented Dec 17, 2017

We experienced this as well upstream in the webpack template, back when when we upgraded to webpack 3. It turned out that it was related to the html-webpack-template and this code: vuejs-templates/webpack#751 (comment)

So you have this in dev-server.js, and this is the problem:
https://github.com/vuejs-templates/pwa/blob/development/template/build/dev-server.js#L38-L44

We decided to remove that to get HMR going again:

https://github.com/vuejs-templates/webpack/blob/1.1.0/template/build/dev-server.js#L38-L46


Edit: It seems that alone doesn't fix it :( Will look into it more later. If anyone else has an idea, please speak up :) - fix tested and works.

@shaun-sweet
Copy link
Author

shaun-sweet commented Dec 17, 2017

@LinusBorg yea, I noticed the upstream issue as well when I tried a new template on that end. Lemme try what you're suggesting and I'll report back. Thanks for the quick reply!


Edit: Looks good :)

shaun-sweet added a commit to shaun-sweet/portal-project that referenced this issue Dec 17, 2017
@Kocal
Copy link

Kocal commented Jan 18, 2018

Thanks a lot @LinusBorg, it was very boring... 😞

@daniandl
Copy link

daniandl commented Mar 8, 2018

@LinusBorg This causes very weird behavior with styling files for me, have you found another work around?

@LinusBorg
Copy link
Contributor

No. Also I don't see how this could influence styling.

@daniandl
Copy link

daniandl commented Mar 8, 2018

Ended up being a tricky sass :export {} "bug". Hope it helps the next person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants