Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customised MenuList continuously loads. #58

Open
dwjohnston opened this issue May 27, 2020 · 1 comment
Open

Customised MenuList continuously loads. #58

dwjohnston opened this issue May 27, 2020 · 1 comment

Comments

@dwjohnston
Copy link

dwjohnston commented May 27, 2020

Are you submitting a bug report or a feature request?

What is the current behavior?

When customising MenuList max-height and overflow-y are lost, which causes the pagination/lazy loading to continuously load.

This is even when using wrapMenuList.

What is the expected behavior?

Max height and overflow-y should be set, or documentation should be updated highlighting this.

Sandbox Link

https://codesandbox.io/s/simple-example-xwdbr?file=/src/App.jsx

What's your environment?

See sandbox.

The customised MenuList I'm using comes from Material-UI.

Other information

This is easily solved by adding:

style = {{maxHeight: '300px', overflowY: 'auto'}}

which the wrapMenuList function can probably provide.

If you like I can create a PR for this.

@dwjohnston dwjohnston changed the title onChange type definition is incorrect for Customised MenuList continuously loads. May 27, 2020
@vtaits
Copy link
Owner

vtaits commented May 29, 2020

Thank you. I will update documentation a little later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants