Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Block] Add proper close to RtlSdrSource #8

Closed
vsergeev opened this issue Jul 1, 2016 · 0 comments
Closed

[Block] Add proper close to RtlSdrSource #8

vsergeev opened this issue Jul 1, 2016 · 0 comments
Labels
block bug
Milestone
v0.2.0

Comments

@vsergeev
Copy link
Owner

vsergeev commented Jul 1, 2016

The RtlSdrSource block is forcibly killed by SIGTERM on flow graph termination, and does not have a chance to call rtlsdr_close() on its device handle. It should install a signal handler on SIGTERM that gives it a chance to properly close the device before exiting.
@vsergeev vsergeev added this to the v0.2.0 milestone Jul 1, 2016
@vsergeev vsergeev changed the title Add proper close to RtlSdrSource [Block] Add proper close to RtlSdrSource Jul 1, 2016
vsergeev added a commit that referenced this issue Jul 5, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to cancel reading
9006298 
and allow device close after rtlsdr_read_async() returns.

resolves #8.
vsergeev added a commit that referenced this issue Jul 5, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to cancel reading
3496a8f 
and allow device close after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 5, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
9e56ad9 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 6, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
151ea42 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 6, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
9398b39 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 6, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
2da8b7a 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 8, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
4bea367 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 8, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
891edc7 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 10, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
cbdd3a9 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 10, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
2bd97bb 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 10, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
bf309c3 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 10, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
f1cd315 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
vsergeev added a commit that referenced this issue Jul 17, 2016
@vsergeev
blocks/sources/rtlsdr: add sigterm handler to allow device close
1c945a6 
the sigterm handlers cancel's the async read, allowing device close
after rtlsdr_read_async() returns.

also rename read_async_callback to read_callback for less ambiguity
between it and the async.callback() helper function.

resolves #8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
block bug
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@vsergeev