Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix destroying focused udon objects #80

Merged
merged 1 commit into from
May 16, 2023
Merged

fix destroying focused udon objects #80

merged 1 commit into from
May 16, 2023

Conversation

cubedparadox
Copy link
Contributor

null checks to fix clientsim exploding when you destroy gameobjects with udon

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@cubedparadox cubedparadox requested review from orels1 and Hakkniv May 2, 2023 18:21
@cubedparadox
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@momo-the-monster momo-the-monster linked an issue May 3, 2023 that may be closed by this pull request
Destroying focused object breaks Client sim (Works fine in VRChat) #59
Open
momo-the-monster
momo-the-monster approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@momo-the-monster momo-the-monster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and fixes the issue for me when calling Object.Destroy() on the selected GameObject.

@cubedparadox cubedparadox changed the base branch from releases/1.2.3 to releases/1.2.4 May 16, 2023 19:29
@cubedparadox cubedparadox merged commit 9c93785 into releases/1.2.4 May 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
@momo-the-monster momo-the-monster deleted the bugfix/59-destroying-focused-object branch January 16, 2025 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@momo-the-monster momo-the-monster momo-the-monster approved these changes

@orels1 orels1 Awaiting requested review from orels1

@Hakkniv Hakkniv Awaiting requested review from Hakkniv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Destroying focused object breaks Client sim (Works fine in VRChat)
2 participants
@cubedparadox @momo-the-monster