Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_provider fact not mocked correctly / consistently #124

Closed
zilchms opened this issue Feb 10, 2024 · 1 comment
Closed

service_provider fact not mocked correctly / consistently #124

zilchms opened this issue Feb 10, 2024 · 1 comment

Comments

@zilchms
Copy link

zilchms commented Feb 10, 2024

There seems to exist a problem where the service_provider fact is not correctly or consistently mocked.
The module itself seems to get the correct facts, the spec tests on the other hand seem to sometimes not get these facts (even though os_facts gets loaded correctly)
The problem itself seems to occur a bit random, but then consistently (retriggering the workflow does not lead to correct provisioning)

Eg. https://github.com/voxpupuli/puppet-kafka/actions/runs/7799015682/job/21269032637?pr=336#step:5:22

@bastelfreak could reproduce this accross multiple modules.
I am not sure whether this is a problem of this gem or a more general problem for rspec test implementation accross our modules.
This issue serves the purpose to track the issue.

@ekohl
Copy link
Member

ekohl commented Feb 10, 2024

The problem is that rspec-puppet-facts uses strings for custom facts, not symbols. voxpupuli/rspec-puppet-facts#157 will make it consistent but I've opened in the short term voxpupuli/puppet-kafka#351 for that specific module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants