-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old hardcoded list of repo excludes #324
Comments
I'd like to voice my concern about this. My goal is to get rid of Have you considered using a repository label in Github? Something like |
I thought about the repository labels/topics as well. With the .sync.yml we have the advantage of a review/permission management. I just checked https://docs.github.com/en/github/administering-a-repository/managing-repository-settings/classifying-your-repository-with-topics and only admins can currently manage topis, so that might not be too bad. |
The advantage of a YAML file (whatever it is named) is in my opinion the possibility for different options (eg. disable a specific check, disable comments for a specific check). Currently we only support three flags but I think this will become more and more as we also might introduce new checks or more comments/actions for different things. Managing them all through topics would be pretty confusing I think as there is no possibility for nesting them. I not necessarily need the configuration to happen in the |
Perhaps #304 (comment) was meant for this issue. |
In the voxpupuli.yml we keep a (short) list of repos we exlcude. Since we now support configuration we should remove that once every repo has implemented the
enabled: false
flag to the.sync.yml
.List:
The text was updated successfully, but these errors were encountered: