How do you remove an existing Windows Firewall rule?

[mike406]

    windows_firewall::exception { 'OpenSSH-Server-In-TCP':
        ensure          => 'absent',
        direction       => 'in',
        action          => 'allow',
        display_name    => 'OpenSSH SSH Server (sshd)'
    }

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Left match operand must result in a String value. Got an Undef Value. (file: /etc/puppetlabs/code/environments/production/modules/windows_firewall/manifests/exception.pp, line: 106, column: 8) (file: /etc/puppetlabs/code/environments/production/modules/win_sshd/manifests/init.pp, line: 36)

[mike406]

Figured it out...just need protocol and display_name

    windows_firewall::exception { 'OpenSSH-Server-In-TCP':
        ensure          => 'absent',
        protocol        => 'TCP',
        display_name    => 'OpenSSH SSH Server (sshd)'
    }

This module's readme (or error message) needs to have more clear indication of what parameters are required to get things done. Leaving this open so that can be addressed.

On another note, it would also be nice for this to support rules with protocol other than TCP, UDP, ICMPv4/v6

[ghoneycutt]

@mike406 Could you please add this to the README?

https://github.com/voxpupuli/puppet-windows_firewall/edit/master/README.md