Systemd Service/wrapped init script is not able to shut down Bitbucket

[SimonHoenscheid]

Affected Puppet, Ruby, OS and module versions/distributions

Not a Puppet issue

How to reproduce (e.g Puppet code you use)

Install recent Bitbucket version

What are you seeing

The Systemd service is able to start, but not to stop the Bitbucket server. I think the reason is inside the wrapped init.d script.

What behaviour did you expect instead

The Service can be started and stopped.

Output log

Any additional information you'd like to impart

[igalic]

do you have a solution in mind?

[SimonHoenscheid]

@igalic I have three solutions in mind: The module still pours a classical sysv-init file on debian, even a more modern systemd file is already available for ubuntu. I would check the condition for redhat and then maybe just go for the systemd file.

The condition which decides for a different pidfile does not work, I would check Bitbucket EOL dates and then make this generic.

I would also add a symlink bitbucket.service -> stash.service

[igalic]

if the underlying system supports systemd, we should be rolling out systemd service files

the nice thing there is that thanks to cgroups, we don't even almost care about pid files

if the underlying system doesn't support systemd, or anything else remotely sensible, we put our heads together, and fix the init template

[SimonHoenscheid]

igalic we don't, but tomcat seems to be a snob,