cs_location always change on rocky8/9

[teluq-pbrideau]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 7
• Ruby: 2.7.8p225
• Distribution: Rocky8, Rocky9
• Module version: master

How to reproduce (e.g Puppet code you use)

The same code as described in the readme:

cs_location { 'vip-ping-connected':
  primitive => 'vip',
  rules     => [
    { 'vip-ping-exclude-rule' => {
        'score'      => '-INFINITY',
        'expression' => [
          { 'attribute' => 'pingd',
            'operation' => 'lt',
            'value'     => '100',
          },
        ],
      },
    },
    { 'vip-ping-prefer-rule' => {
        'score-attribute' => 'pingd',
        'expression'      => [
          { 'attribute' => 'pingd',
            'operation' => 'defined',
          }
        ],
      },
    },
  ],
}

What are you seeing

Puppet detect a change at every run. The change that is detected is the quote for the score-attribute:
'score-attribute' => '"pingd"', => 'score-attribute' => 'pingd',

What behaviour did you expect instead

Once configured, puppet should not detect a change everytime.

Output log

Notice: /Stage[main]/Profile::Vip/Cs_location[vip-ping-connected]/rules: rules changed [
  {
    'vip-ping-exclude-rule' => {
      'score' => '-INFINITY',
      'expression' => [
        {
          'operation' => 'lt',
          'attribute' => 'pingd',
          'value' => '100'
        }]
    }
  },
  {
    'vip-ping-prefer-rule' => {
      'score-attribute' => '"pingd"',
      'expression' => [
        {
          'operation' => 'defined',
          'attribute' => 'pingd'
        }]
    }
  }] to [
  {
    'vip-ping-exclude-rule' => {
      'score' => '-INFINITY',
      'expression' => [
        {
          'attribute' => 'pingd',
          'operation' => 'lt',
          'value' => '100'
        }]
    }
  },
  {
    'vip-ping-prefer-rule' => {
      'score-attribute' => 'pingd',
      'expression' => [
        {
          'attribute' => 'pingd',
          'operation' => 'defined'
        }]
    }
  }] (corrective)

Any additional information you'd like to impart

The fix is trivial, i’ll submit the PR right away