Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI.open via Kernel#open is deprecated #449

Open
estolfo opened this issue Jan 6, 2021 · 0 comments
Open

URI.open via Kernel#open is deprecated #449

estolfo opened this issue Jan 6, 2021 · 0 comments

Comments

@estolfo
Copy link

estolfo commented Jan 6, 2021

Hi!
Ruby 3.0 has removed support for URI.open via Kernel#open, making these lines fail:

I was going to open a PR to change those lines but I noticed in your CI that you run your tests against ruby versions back to 1.9.
It seems that URI.open was made public in ruby 2.4. I guess the two options would be to drop support for ruby < 2.4 or use URI.send(:open, ...), which should work for all versions of ruby that you support (I have not verified this yet).

I'm happy to open a pull request and update your test matrix, just let me know what you'd like to do!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant