Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tagging doku and commands #10

Open
rwaffen opened this issue Sep 6, 2024 · 0 comments
Open

Update Tagging doku and commands #10

rwaffen opened this issue Sep 6, 2024 · 0 comments

Comments

@rwaffen
Copy link
Member

rwaffen commented Sep 6, 2024

We have this too in other places, but I feel it's broken for a bit of a nit pick reason.

If you have a merge commit then the history is very confusing because you end up tagging the merge commit, not the commit named "Release $version". Because of that I'm more a fan of a fast forward merge and tag that.

For Foreman releases I use https://github.com/theforeman/foreman-installer-modulesync/blob/master/bin/release-merge which calls https://github.com/theforeman/foreman-installer-modulesync/blob/master/bin/release-module to actually release. Note we don't have release actions to run after a push, so for Vox Pupuli it could be simplified.

This works well together with https://github.com/theforeman/foreman-installer-modulesync/blob/master/bin/release-pr to create the actual PR.

Originally posted by @ekohl in voxpupuli/container-puppetserver#115 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant