Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for windowsfips 2016 x64 #390

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

skyamgarp
Copy link
Contributor

This PR is to add support for windowsfips 2016.
Before:

bundle exec beaker-hostgenerator redhat8-64mcd-windowsfips2016-64f
---
HOSTS:
  redhat8-64-1:
    platform: el-8-x86_64
    hypervisor: vmpooler
    template: redhat-8-x86_64
    roles:
    - agent
    - master
    - dashboard
    - database
  windowsfips2016-64-1:
    hypervisor: vmpooler
    roles:
    - agent
    - frictionless

With this PR:

bundle exec beaker-hostgenerator redhat8-64mcd-windowsfips2016-64f       
---
HOSTS:
  redhat8-64-1:
    platform: el-8-x86_64
    hypervisor: vmpooler
    template: redhat-8-x86_64
    roles:
    - agent
    - master
    - dashboard
    - database
  windowsfips2016-64-1:
    platform: windows-2016-64
    packaging_platform: windowsfips-2016-x64
    ruby_arch: x64
    template: win-2016-fips-x86_64
    hypervisor: vmpooler
    roles:
    - agent
    - frictionless

@kenyon
Copy link
Member

kenyon commented Nov 26, 2024

Should there also be test files like was done in #364?

(windowsfips2016-support) Added test fixtures

(windowsfips2016-support) Fixtures with rake task
@skyamgarp
Copy link
Contributor Author

Should there also be test files like was done in #364?

I have added them.

@kenyon kenyon merged commit ffba51f into voxpupuli:master Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants