Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetImagesAction and GetFilesAction return invalid paths for files in subfolders #145

Open
XzAeRo opened this issue Oct 19, 2018 · 0 comments
Open

GetImagesAction and GetFilesAction return invalid paths for files in subfolders #145

XzAeRo opened this issue Oct 19, 2018 · 0 comments

Comments

@XzAeRo
Copy link

XzAeRo commented Oct 19, 2018

Since the findFiles() function is recursive and retrieves the files in subfolders, those files generate invalid links.

The culprit is here:

yii2-imperavi-widget/src/actions/GetImagesAction.php

Line 89 in 5d5ecb2

$file = basename($path);

The fix should not get just the basename, but the basename and the subfolder (maybe a substring deletion?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XzAeRo