Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL version detection during install #1224

Open
xsrvmy opened this issue May 4, 2022 · 5 comments
Open

OpenSSL version detection during install #1224

xsrvmy opened this issue May 4, 2022 · 5 comments

Comments

@xsrvmy
Copy link

xsrvmy commented May 4, 2022

This came up in #1150 twice already. The installer assumes that the version supplied by the openssl executable is the one to use, which can cause a problem if the openssl executable is not from the system, or if multiple versions of libssl are installed (no longer a problem with 3.0 support). Some better way of handling this is required. I think one of the following should work:

  • Detecting so names (doesn't the installer already do that afterwards anyways?)
  • Allowing the version to be overriden
@charlespierce
Copy link
Contributor

@xsrvmy Thanks for pulling this into its own issue. This is definitely a concern, especially with the linuxbrew example in the linked issue being a case where the openssl executable that runs isn't the system one. We don't do general soname detection, the installer has a specific case for CentOS systems, that have their own unique (custom-built) version of OpenSSL, so it detects that special case only.

Short-term, a version override (along with some docs about how to use it prominently linked somewhere) may be the easiest approach. More medium term, I have a draft PR out right now #1214 that switches to a statically-linked TLS implementation (also see volta-cli/rfcs#47 for more background), which would sidestep this issue entirely.

@jrock2004
Copy link

Is this the issue to watch as I am unable to install Volta at all on PopOS

@charlespierce
Copy link
Contributor

Hi @jrock2004, I'm unfamiliar with PopOS. What is the error you are seeing when trying to install?

@jrock2004
Copy link

It is the OpenSSL version mismatch. I went ahead and installed arch. Let me try booting into popos and see if issue remains.

@jrock2004
Copy link

@charlespierce Here is the error

volta-error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants