fix: go mod confliction #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwdef
reviewed
Nov 21, 2024
Vacant2333
force-pushed
the
fix-go-mod-conflicat
branch
from
2a7c439 to
1a1b96e
Compare
Vacant2333
force-pushed
the
fix-go-mod-conflicat
branch
from
1a1b96e to
625b22f
Compare
Monokaix
reviewed
Dec 6, 2024
Monokaix
reviewed
Dec 6, 2024
Vacant2333
force-pushed
the
fix-go-mod-conflicat
branch
from
625b22f to
6135c27
Compare
Signed-off-by: Vacant2333 <[email protected]>
Vacant2333
force-pushed
the
fix-go-mod-conflicat
branch
from
6135c27 to
935369b
Compare
Vacant2333
commented
Dec 7, 2024
| kubectl --context karmada-host -n kube-system apply -f https://github.com/emberstack/kubernetes-reflector/releases/download/v7.1.262/reflector.yaml | ||
| kubectl --context karmada-host annotate secret kubeconfig \ | ||
| kubectl --context karmada-host annotate secret karmada-webhook-config \ |
There was a problem hiding this comment.
Karmada removes the kubeconfig secret, we must get the kubeconfig from the another secret
Vacant2333
commented
Dec 7, 2024
| // PR ref: https://github.com/karmada-io/karmada/commit/3058bbf50b953d02166625e2b797cb16c7f26396 | ||
| replace github.com/karmada-io/karmada => github.com/Vacant2333/karmada v0.0.0-20240606155424-3058bbf50b95 | ||
| // Ref: https://github.com/Vacant2333/karmada/tree/suspend-rb-2 | ||
| replace github.com/karmada-io/karmada => github.com/Vacant2333/karmada v0.0.0-20241207135009-0a9b0e40a707 |
There was a problem hiding this comment.
change to the correct branch, we will remove this when karmada supports resource binding suspension
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the go mod confliction, and update the readme quick start
FIx: ##4