Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package request: Sunflower 0.4 (62) #25062

Open
gorkawien opened this issue Sep 23, 2020 · 14 comments
Open

Package request: Sunflower 0.4 (62) #25062

gorkawien opened this issue Sep 23, 2020 · 14 comments
Labels
request Package request

Comments

@gorkawien
Copy link

Sunflower is a small and highly customizable twin-panel file manager for Linux with support for plugins. It is intended to be an easy-to-use and powerful file manager that seamlessly integrates into the GNOME desktop environment (but not limited to).

https://sunflower-fm.org
https://github.com/MeanEYE/Sunflower

@reback00
Copy link
Contributor

reback00 commented Oct 3, 2020

I have prepared a template for Sunflower, but unfortunately it keeps hanging, nothing shows up. Maybe I did some silly mistake. To be on the safe side, I submitted an issue here.

Have you faced this issue on Void Linux before? Have you tried to build it manually, without XBPS?

@gorkawien
Copy link
Author

My first try was to use xdeb, after that i spoke with a mate in a Telegram channel, and we made some advance, but not to the end.
There is an open thread on the mailing list:
https://groups.google.com/g/sunflower-fm/c/aRfN-MkW72s
I put there our progess.
Maybe if we unite our effort, we can finally get a working template!!
I will take a look at you template.
Thanks in advance!!

@gorkawien
Copy link
Author

@reback00 I saw a few differences between our templatetes.
Here is ours:
https://imgur.com/a/dUWGemj

@reback00
Copy link
Contributor

reback00 commented Oct 5, 2020

@gorkawien OK, good template you got there. Especially, I like the version value being set to 0.4.62. Makes better sense than mine.

But it seems on your template it will need python3-setuptools on hostdepends. And possibly it will need some more depends after that. I got them solved in mine. I don't have any build errors. But the problem seems to be that some changes are not updated in master yet for it to work in Void Linux.

As suggested by the author, I tried their develop branch and it partially worked. I think the path error that I got in develop branch, is fixable through a patch to the source code (even if they don't push any changes for that). But can we push a develop branch package to void-packages repo? I don't think it will be accepted. I think this will be a problem if the changes are not merged to master soon.

@gorkawien
Copy link
Author

@reback00
Thanks for your feedback!
My skills are very limited, and your feedback will help me to learn!!
I will share your comments with the person that helped me to build the template, and see if we can do some progress.

@reback00
Copy link
Contributor

reback00 commented Oct 5, 2020

@gorkawien Well, there is a good news!

I think the path error that I got in develop branch, is fixable through a patch to the source code

It seems I was right about this. I tried a patch and it works! I have pushed a sunflower-dev package here if you want to try. So even if it doesn't work on master or if this package doesn't get accepted, you have a working package template! Be sure to test it before use though. I haven't used it thoroughly.

I haven't tried the patch on master yet. If the patch can fix master too, maybe we can hope for a package soon!

I'll also communicate this patch in the issue to see if the author can give us any solution.

@gorkawien
Copy link
Author

gorkawien commented Oct 6, 2020

@rebackOO
Thank you very much!!
I had to change the checksum.
the correct one is:
5f408a35f249eb0a1a544acab5910849a233dd968b160aaa247b3dc21f47ce42

After that i installed on my driver
I have to do some more test, but for now is working fine.

@reback00
Copy link
Contributor

reback00 commented Oct 7, 2020

I had to change the checksum.

That's kind of expected. The checksum will change when there is a new commit in devel. The distfile url just downloads what's in devel. So whenever there's an update on that branch, it changes checksum with it. I added an @ as suggested by Manual.md:

If a distfile changes its checksum for every download because it is packaged on the fly on the server, like e.g. snapshot tarballs from any of the https://*.googlesource.com/ sites, the checksum of the archive contents can be specified by prepending a commercial at (@). For tarballs you can find the contents checksum by using the command tar xf <tarball.ext> --to-stdout | sha256sum.

I thought it would pass it as being ok even if it changes because I added the @. But I guess it doesn't work that way.

@gorkawien
Copy link
Author

@reback00
Regarding the patches you included, could this affect the support for certain icon themes??
I included papirus-icon-theme in my last release of AgarimOS Gnome and I have this feeling that Sunflower doesn't display the folders correctly as it does with other icon-themes.

@reback00
Copy link
Contributor

reback00 commented Oct 9, 2020

@gorkawien I am using Qogir icon theme and it's showing the icons fine. Also, I tried papirus icons, and it seems to be working on my end too:

sunflower06

I have changed icon theme with lxappearance.

The patch just hardcodes the path to main.css, but the file stays the same. So it should work without problems like the upstream intended. If you still face issues I'm afraid you'll have to post an issue to upstream.

@bugcrazy
Copy link
Contributor

bugcrazy commented Jun 8, 2021

I had to change the checksum.

That's kind of expected. The checksum will change when there is a new commit in devel. The distfile url just downloads what's in devel. So whenever there's an update on that branch, it changes checksum with it. I added an @ as suggested by Manual.md:

If a distfile changes its checksum for every download because it is packaged on the fly on the server, like e.g. snapshot tarballs from any of the https://*.googlesource.com/ sites, the checksum of the archive contents can be specified by prepending a commercial at (@). For tarballs you can find the contents checksum by using the command tar xf <tarball.ext> --to-stdout | sha256sum.

I thought it would pass it as being ok even if it changes because I added the @. But I guess it doesn't work that way.

"But shells parse all the time. Worse, the essence of the shell is parsing: the parser and the runner are intimately interleaved and cannot be clearly separated, thanks to the specification. The shell performs several kinds of expansions, automatic filename globbing, and automatic word splitting, in an unintuitive order, requiring users to memorize numerous arbitrary quoting rules in order to achieve what they want. Pages abound where common mistakes are listed, more often than not leading to security holes. Did you know that "$@" is a special case of double quoting, because it will split the arguments into several words, whereas every other use of double quotes in a shell is meant to prevent splitting?"

@niels0n
Copy link

niels0n commented May 10, 2023

Hey there, I was trying to use Sunflower and create a template but I'm struggling and I found this discussion.
Is there any update on this?

@bugcrazy
Copy link
Contributor

Nope!

@niels0n
Copy link

niels0n commented May 10, 2023

I actually have just seen that the @reback00's template seems to work. Is there something wrong with it?

MIvanchev added a commit to MIvanchev/void-packages that referenced this issue Oct 4, 2024
MIvanchev added a commit to MIvanchev/void-packages that referenced this issue Oct 4, 2024
MIvanchev added a commit to MIvanchev/void-packages that referenced this issue Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Package request
Projects
None yet
Development

No branches or pull requests

5 participants