You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After thinking about it more, I'm going to replace the "splits_path" parameter with "metadata_path", as discussed in vocalpy/CMACBench#4
We already include splits as part of the metadata with datasets that are prepped by vak.prep for use with model-specific datapipes, so we should just extend this logic to the built-in dataset
This also lets us remove the gross function in vak.datasets.cmacbench.helper that infers metadata from a naming scheme, and the dataclass that goes along with it. Instead we'll just convert the other dataclass that's currently called vak.datasets.cmacbench.helper.SplitsJson to Metadata like we have for datasets that vak can prep, and in that way declare programatically what is required in the metadata, as far as vak is concerned: in this case, the frame duration, the path to the splits csv, the path to the bookkeeping vectors, and the path to the labelmap in json
And it lets us avoid adding some even more convoluted classmethod
transforms
,helper
,cmacbench
so we don't have a single 750 line moduleadd classmethodfrom_config
that we can call like soCMACBench.from_config(**dataset_config)
move logic for determining labelmap to classmethodto classmethod, add arglabelmap_path
that allows us to specify an alternate labelmap; if none is provided, use default labelmap insteadThe text was updated successfully, but these errors were encountered: