Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Have vak.predict accept post_tfm_kwargs like eval + learncurve #714

Open
NickleDave opened this issue Oct 3, 2023 · 0 comments
Open

ENH: Have vak.predict accept post_tfm_kwargs like eval + learncurve #714

NickleDave opened this issue Oct 3, 2023 · 0 comments

Comments

@NickleDave
Copy link
Collaborator

NickleDave commented Oct 3, 2023 •
edited
Loading

This came up in this related bug:
#697 (comment)

It's surprising that we specify the parameters for the post-processing transformation as separate options in the predict section of the config, but then specify them in a "sub-table" named post_tfm_kwargs in the eval and learncurve sections

We should change predict to be consistent with the others IMO since we may want to change the semantics of post_tfm_kwargs depending on the model family
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickleDave