From 7d17594093934e63fe5b1e00348cb56e415e4144 Mon Sep 17 00:00:00 2001 From: Le Tan Date: Sun, 17 Sep 2023 21:55:28 +0800 Subject: [PATCH 01/11] try fix win ci --- .github/workflows/ci-win.yml | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/.github/workflows/ci-win.yml b/.github/workflows/ci-win.yml index 53b9d612c2..9135670dc1 100644 --- a/.github/workflows/ci-win.yml +++ b/.github/workflows/ci-win.yml @@ -21,29 +21,17 @@ jobs: strategy: matrix: config: - # - { - # name: "Build On Win64 Qt 5.12", - # arch: win64_msvc2017_64, - # platform: x64, - # qt: 5.12.11 - # } - # - { - # name: "Build On Win32 Qt 5.12", - # arch: win32_msvc2017, - # platform: x86, - # qt: 5.12.11 - # } - { - name: "Build On Win64 Qt 5.15", + name: "Build On Win64 Qt 6.5", arch: win64_msvc2019_64, platform: x64, - qt: 5.15.2 + qt: 6.5.2 } - { - name: "Build On Win32 Qt 5.15", + name: "Build On Win32 Qt 6.5", arch: win32_msvc2019, platform: x86, - qt: 5.15.2 + qt: 6.5.2 } steps: @@ -64,16 +52,16 @@ jobs: uses: actions/cache@v1 # not v2! with: path: ../Qt - key: ${{ runner.os }}-${{matrix.config.arch}}-QtCache-5.12-1 + key: ${{ runner.os }}-${{matrix.config.arch}}-QtCache-6.5 - name: Install Qt Official Build - uses: jurplel/install-qt-action@v2 + uses: jurplel/install-qt-action@v3 with: version: ${{matrix.config.qt}} target: desktop arch: ${{matrix.config.arch}} modules: qtwebengine - tools: tools_openssl_${{matrix.config.platform}},1.1.1-4,qt.tools.openssl.win_${{matrix.config.platform}} + tools: tools_openssl_${{matrix.config.platform}},3.0.10,qt.tools.openssl.win_${{matrix.config.platform}} cached: ${{ steps.cache-qt.outputs.cache-hit }} - name: Create Build Dir From 5b7697f2557a84352e3a353e20153a85e564bd6c Mon Sep 17 00:00:00 2001 From: Le Tan Date: Sun, 17 Sep 2023 22:30:20 +0800 Subject: [PATCH 02/11] remove win32 --- .github/workflows/ci-win.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci-win.yml b/.github/workflows/ci-win.yml index 9135670dc1..977e24e950 100644 --- a/.github/workflows/ci-win.yml +++ b/.github/workflows/ci-win.yml @@ -27,12 +27,6 @@ jobs: platform: x64, qt: 6.5.2 } - - { - name: "Build On Win32 Qt 6.5", - arch: win32_msvc2019, - platform: x86, - qt: 6.5.2 - } steps: # Checks-out your repository under $GITHUB_WORKSPACE. @@ -60,9 +54,9 @@ jobs: version: ${{matrix.config.qt}} target: desktop arch: ${{matrix.config.arch}} - modules: qtwebengine - tools: tools_openssl_${{matrix.config.platform}},3.0.10,qt.tools.openssl.win_${{matrix.config.platform}} - cached: ${{ steps.cache-qt.outputs.cache-hit }} + modules: 'qtwebengine qt5compat' + tools: tools_opensslv3_${{matrix.config.platform}} + cache: 'true' - name: Create Build Dir shell: bash From 23bc1fc3c60dd17952d9ae1b6c7a6b2695372e42 Mon Sep 17 00:00:00 2001 From: Le Tan Date: Mon, 18 Sep 2023 10:33:28 +0800 Subject: [PATCH 03/11] add more modules --- .github/workflows/ci-win.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-win.yml b/.github/workflows/ci-win.yml index 977e24e950..627410d890 100644 --- a/.github/workflows/ci-win.yml +++ b/.github/workflows/ci-win.yml @@ -54,7 +54,7 @@ jobs: version: ${{matrix.config.qt}} target: desktop arch: ${{matrix.config.arch}} - modules: 'qtwebengine qt5compat' + modules: 'qtwebengine qtwebchannel qtpositioning qtpdf qtimageformats qt5compat' tools: tools_opensslv3_${{matrix.config.platform}} cache: 'true' From 6ebc70709c5730ed931d19745440764f914a581e Mon Sep 17 00:00:00 2001 From: Le Tan Date: Mon, 18 Sep 2023 21:58:13 +0800 Subject: [PATCH 04/11] fix ci --- .github/workflows/ci-win.yml | 12 +----------- package/qt.conf | 2 ++ 2 files changed, 3 insertions(+), 11 deletions(-) create mode 100644 package/qt.conf diff --git a/.github/workflows/ci-win.yml b/.github/workflows/ci-win.yml index 627410d890..abaeb25f57 100644 --- a/.github/workflows/ci-win.yml +++ b/.github/workflows/ci-win.yml @@ -63,12 +63,6 @@ jobs: run: mkdir build working-directory: ${{runner.workspace}} - - name: Clone OpenSSL - shell: bash - run: | - git clone https://github.com/tamlok/openssl-utils.git openssl-utils.git --depth=1 - working-directory: ${{runner.workspace}}/build - - name: Configure and Build Project shell: cmd run: | @@ -89,11 +83,7 @@ jobs: copy .\src\release\vnote_extra.rcc "%DISTRIB_PATH%\vnote_extra.rcc" copy .\libs\vtextedit\src\libs\syntax-highlighting\release\VSyntaxHighlighting.dll "%DISTRIB_PATH%\VSyntaxHighlighting.dll" copy .\libs\vtextedit\src\editor\release\VTextEdit.dll "%DISTRIB_PATH%\VTextEdit.dll" - rem set qt_dir=%Qt5_Dir:/=\% - rem for %%I in ("%qt_dir%\..\..") do set "qt_topdir=%%~fI" - rem set openssl_dir=%qt_topdir%\Tools\OpenSSL\Win_${{matrix.config.platform}}\bin - set openssl_dir=openssl-utils.git\1.1.1j\Win_${{matrix.config.platform}} - copy %openssl_dir%\lib*.dll "%DISTRIB_PATH%\" + copy "%GITHUB_WORKSPACE%\package\qt.conf" "%DISTRIB_PATH%\qt.conf" copy "%GITHUB_WORKSPACE%\README.md" "%DISTRIB_PATH%\README.md" copy "%GITHUB_WORKSPACE%\COPYING.LESSER" "%DISTRIB_PATH%\COPYING.LESSER" echo %GITHUB_SHA% > "%DISTRIB_PATH%\commit" diff --git a/package/qt.conf b/package/qt.conf new file mode 100644 index 0000000000..367a59eeb6 --- /dev/null +++ b/package/qt.conf @@ -0,0 +1,2 @@ +[Platforms] +WindowsArguments = fontengine=freetype From f76d8f39fa80c808dcf6a1970ffc7739887a75f4 Mon Sep 17 00:00:00 2001 From: Le Tan Date: Tue, 19 Sep 2023 15:20:15 +0800 Subject: [PATCH 05/11] try fix linux-ci --- .github/workflows/ci-linux.yml | 35 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/.github/workflows/ci-linux.yml b/.github/workflows/ci-linux.yml index b1e2c734c5..282dc621e2 100644 --- a/.github/workflows/ci-linux.yml +++ b/.github/workflows/ci-linux.yml @@ -38,23 +38,23 @@ jobs: - name: Install dependencies run: | sudo DEBIAN_FRONTEND=noninteractive apt-get update - sudo DEBIAN_FRONTEND=noninteractive apt-get install -y libfcitx-qt5-dev tree + sudo DEBIAN_FRONTEND=noninteractive apt-get install -y libfcitx5-qt-dev tree - name: Cache Qt id: cache-qt uses: actions/cache@v1 # not v2! with: path: ../Qt - key: ${{ runner.os }}-QtCache-5.15 + key: ${{ runner.os }}-QtCache-6.5 - name: Install Qt - uses: jurplel/install-qt-action@v2 + uses: jurplel/install-qt-action@v3 with: - version: 5.15.2 + version: 6.5.2 target: desktop - modules: qtwebengine - tools: tools_openssl_x64,1.1.1-4,qt.tools.openssl.gcc_64 - cached: ${{ steps.cache-qt.outputs.cache-hit }} + modules: 'qtwebengine qtwebchannel qtpositioning qtpdf qtimageformats qt5compat' + tools: tools_opensslv3_${{matrix.config.platform}} + cache: 'true' - name: Create Build Dir run: mkdir build @@ -62,19 +62,18 @@ jobs: - name: Compile qt5ct run: | - wget --no-check-certificate -c https://versaweb.dl.sourceforge.net/project/qt5ct/qt5ct-1.1.tar.bz2 - tar xf qt5ct-1.*.tar.bz2 - cd qt5ct-1.*/ - QT_SELECT=5 qmake + git clone https://github.com/trialuser02/qt6ct qt6ct.git + cd qt6ct.git + qmake make -j$(nproc) && sudo make install working-directory: ${{runner.workspace}}/build - name: Configure Project run: | qmake -v - cp /usr/lib/x86_64-linux-gnu/qt5/plugins/platforminputcontexts/libfcitxplatforminputcontextplugin.so ./ + cp /usr/lib/x86_64-linux-gnu/qt6/plugins/platforminputcontexts/libfcitxplatforminputcontextplugin.so ./ sudo chmod +rwx ./libfcitxplatforminputcontextplugin.so - cp ./libfcitxplatforminputcontextplugin.so $Qt5_Dir/plugins/platforminputcontexts + cp ./libfcitxplatforminputcontextplugin.so $Qt6_Dir/plugins/platforminputcontexts qmake CONFIG+=release -spec linux-g++-64 ${GITHUB_WORKSPACE}/vnote.pro working-directory: ${{runner.workspace}}/build @@ -96,16 +95,16 @@ jobs: LD_LIBRARY_PATH=$PWD/lib:$LD_LIBRARY_PATH # Copy translations mkdir -p AppDir/usr/translations - cp $Qt5_Dir/translations/qt_zh_CN.qm AppDir/usr/translations + cp $Qt6_Dir/translations/qt_zh_CN.qm AppDir/usr/translations # Package qt5ct (EXTRA_QT_PLUGINS seems not work) # EXTRA_QT_PLUGINS="platformthemes/libqt5ct.so;styles/libqt5ct-style.so" mkdir -p AppDir/usr/plugins/platformthemes mkdir -p AppDir/usr/plugins/styles - cp $Qt5_Dir/plugins/platformthemes/* AppDir/usr/plugins/platformthemes/ - cp $Qt5_Dir/plugins/styles/* AppDir/usr/plugins/styles/ + cp $Qt6_Dir/plugins/platformthemes/* AppDir/usr/plugins/platformthemes/ + cp $Qt6_Dir/plugins/styles/* AppDir/usr/plugins/styles/ # Package libssl.so and libcrypto.so - Qt5_Tools=$Qt5_Dir/../../Tools - linuxdeploy-x86_64.AppImage --appdir ./AppDir --plugin qt --output appimage -l $Qt5_Tools/OpenSSL/binary/lib/libcrypto.so.1.1 -l $Qt5_Tools/OpenSSL/binary/lib/libssl.so.1.1 + Qt_Tools=$Qt6_Dir/../../Tools + linuxdeploy-x86_64.AppImage --appdir ./AppDir --plugin qt --output appimage -l $Qt_Tools/OpenSSL/binary/lib/libcrypto.so.* -l $Qt_Tools/OpenSSL/binary/lib/ tree AppDir working-directory: ${{runner.workspace}}/build From fbe9db54fbe0c6a73792a0e1e8fba0f9add3afc6 Mon Sep 17 00:00:00 2001 From: Le Tan Date: Mon, 25 Sep 2023 22:55:31 +0800 Subject: [PATCH 06/11] fix linux ci --- .github/workflows/ci-linux.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci-linux.yml b/.github/workflows/ci-linux.yml index 282dc621e2..4c161cf175 100644 --- a/.github/workflows/ci-linux.yml +++ b/.github/workflows/ci-linux.yml @@ -53,14 +53,13 @@ jobs: version: 6.5.2 target: desktop modules: 'qtwebengine qtwebchannel qtpositioning qtpdf qtimageformats qt5compat' - tools: tools_opensslv3_${{matrix.config.platform}} cache: 'true' - name: Create Build Dir run: mkdir build working-directory: ${{runner.workspace}} - - name: Compile qt5ct + - name: Compile qt6ct run: | git clone https://github.com/trialuser02/qt6ct qt6ct.git cd qt6ct.git @@ -71,9 +70,7 @@ jobs: - name: Configure Project run: | qmake -v - cp /usr/lib/x86_64-linux-gnu/qt6/plugins/platforminputcontexts/libfcitxplatforminputcontextplugin.so ./ - sudo chmod +rwx ./libfcitxplatforminputcontextplugin.so - cp ./libfcitxplatforminputcontextplugin.so $Qt6_Dir/plugins/platforminputcontexts + # TODO: libfcitx5 qmake CONFIG+=release -spec linux-g++-64 ${GITHUB_WORKSPACE}/vnote.pro working-directory: ${{runner.workspace}}/build From d89861234082d3a237408ed214559c420f3526b8 Mon Sep 17 00:00:00 2001 From: Le Tan Date: Tue, 26 Sep 2023 23:08:57 +0800 Subject: [PATCH 07/11] try fix rcc --- .github/workflows/ci-linux.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci-linux.yml b/.github/workflows/ci-linux.yml index 4c161cf175..b4137b8264 100644 --- a/.github/workflows/ci-linux.yml +++ b/.github/workflows/ci-linux.yml @@ -71,6 +71,7 @@ jobs: run: | qmake -v # TODO: libfcitx5 + tree /home/runner/work/vnote/Qt qmake CONFIG+=release -spec linux-g++-64 ${GITHUB_WORKSPACE}/vnote.pro working-directory: ${{runner.workspace}}/build From e38832c4e5af2bcabceb1d7af8743ea34570c04a Mon Sep 17 00:00:00 2001 From: Le Tan Date: Wed, 27 Sep 2023 22:15:08 +0800 Subject: [PATCH 08/11] fix rcc path --- .github/workflows/ci-linux.yml | 2 +- src/src.pro | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-linux.yml b/.github/workflows/ci-linux.yml index b4137b8264..1e2dabe257 100644 --- a/.github/workflows/ci-linux.yml +++ b/.github/workflows/ci-linux.yml @@ -71,7 +71,6 @@ jobs: run: | qmake -v # TODO: libfcitx5 - tree /home/runner/work/vnote/Qt qmake CONFIG+=release -spec linux-g++-64 ${GITHUB_WORKSPACE}/vnote.pro working-directory: ${{runner.workspace}}/build @@ -91,6 +90,7 @@ jobs: # Move the lib out to avoid duplication mv AppDir/usr/lib ./ LD_LIBRARY_PATH=$PWD/lib:$LD_LIBRARY_PATH + Qt6_Dir=$QT_HOST_BINS/.. # Copy translations mkdir -p AppDir/usr/translations cp $Qt6_Dir/translations/qt_zh_CN.qm AppDir/usr/translations diff --git a/src/src.pro b/src/src.pro index 24548eb194..75ecc00209 100644 --- a/src/src.pro +++ b/src/src.pro @@ -79,8 +79,8 @@ win32 { rcc_binary.commands = $$shell_path($$[QT_HOST_BINS]/rcc.exe) -name ${QMAKE_FILE_IN_BASE} -binary ${QMAKE_FILE_IN} -o ${QMAKE_FILE_OUT} rcc_binary.depend_command = $$shell_path($$[QT_HOST_BINS]/rcc.exe) -list $$QMAKE_RESOURCE_FLAGS ${QMAKE_FILE_IN} } else { - rcc_binary.commands = $$[QT_HOST_BINS]/rcc -name ${QMAKE_FILE_IN_BASE} -binary ${QMAKE_FILE_IN} -o ${QMAKE_FILE_OUT} - rcc_binary.depend_command = $$[QT_HOST_BINS]/rcc -list $$QMAKE_RESOURCE_FLAGS ${QMAKE_FILE_IN} + rcc_binary.commands = $$[QT_HOST_LIBEXECS]/rcc -name ${QMAKE_FILE_IN_BASE} -binary ${QMAKE_FILE_IN} -o ${QMAKE_FILE_OUT} + rcc_binary.depend_command = $$[QT_HOST_LIBEXECS]/rcc -list $$QMAKE_RESOURCE_FLAGS ${QMAKE_FILE_IN} } rcc_binary.input = RCC_BINARY_SOURCES rcc_binary.output = $$SRC_DESTDIR/vnote_${QMAKE_FILE_IN_BASE}.rcc From fcbbd433ad86efda317bcc6b81dc11b2ef300f68 Mon Sep 17 00:00:00 2001 From: Le Tan Date: Thu, 28 Sep 2023 22:06:41 +0800 Subject: [PATCH 09/11] tree --- .github/workflows/ci-linux.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci-linux.yml b/.github/workflows/ci-linux.yml index 1e2dabe257..b484b8b3a2 100644 --- a/.github/workflows/ci-linux.yml +++ b/.github/workflows/ci-linux.yml @@ -91,6 +91,8 @@ jobs: mv AppDir/usr/lib ./ LD_LIBRARY_PATH=$PWD/lib:$LD_LIBRARY_PATH Qt6_Dir=$QT_HOST_BINS/.. + tree $Qt6_Dir + tree $Qt6_Dir/../.. # Copy translations mkdir -p AppDir/usr/translations cp $Qt6_Dir/translations/qt_zh_CN.qm AppDir/usr/translations From 59b063e86bc0e0c197dff902f417f65ee24558c5 Mon Sep 17 00:00:00 2001 From: Le Tan Date: Sun, 8 Oct 2023 17:36:16 +0800 Subject: [PATCH 10/11] add back qt 5 --- .github/workflows/ci-win.yml | 46 ++++++++++++++++++++++++++++++++---- 1 file changed, 41 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci-win.yml b/.github/workflows/ci-win.yml index abaeb25f57..63a2f1352f 100644 --- a/.github/workflows/ci-win.yml +++ b/.github/workflows/ci-win.yml @@ -21,11 +21,21 @@ jobs: strategy: matrix: config: + - { + name: "Build On Win64 Qt 5.15", + arch: win64_msvc2019_64, + platform: x64, + qt: 5.15.2, + qt_modules: qtwebengine, + qt_tools: tools_opensslv3_x64 + } - { name: "Build On Win64 Qt 6.5", arch: win64_msvc2019_64, platform: x64, - qt: 6.5.2 + qt: 6.5.2, + qt_modules: "qtwebengine qtwebchannel qtpositioning qtpdf qtimageformats qt5compat", + qt_tools: tools_opensslv3_x64 } steps: @@ -46,7 +56,7 @@ jobs: uses: actions/cache@v1 # not v2! with: path: ../Qt - key: ${{ runner.os }}-${{matrix.config.arch}}-QtCache-6.5 + key: ${{runner.os}}-${{matrix.config.arch}}-QtCache-${{matrix.config.qt}} - name: Install Qt Official Build uses: jurplel/install-qt-action@v3 @@ -54,8 +64,8 @@ jobs: version: ${{matrix.config.qt}} target: desktop arch: ${{matrix.config.arch}} - modules: 'qtwebengine qtwebchannel qtpositioning qtpdf qtimageformats qt5compat' - tools: tools_opensslv3_${{matrix.config.platform}} + modules: ${{matrix.config.qt_modules}} + tools: ${{matrix.config.qt_tools}} cache: 'true' - name: Create Build Dir @@ -63,6 +73,13 @@ jobs: run: mkdir build working-directory: ${{runner.workspace}} + - name: Clone OpenSSL on 5.15 + shell: bash + if: startsWith(${{matrix.config.qt}}, '5.15') + run: | + git clone https://github.com/tamlok/openssl-utils.git openssl-utils.git --depth=1 + working-directory: ${{runner.workspace}}/build + - name: Configure and Build Project shell: cmd run: | @@ -72,7 +89,7 @@ jobs: nmake working-directory: ${{runner.workspace}}/build - - name: Package Project + - name: Package Project 1 shell: cmd run: | qmake --version @@ -88,6 +105,23 @@ jobs: copy "%GITHUB_WORKSPACE%\COPYING.LESSER" "%DISTRIB_PATH%\COPYING.LESSER" echo %GITHUB_SHA% > "%DISTRIB_PATH%\commit" del /F /Q "%DISTRIB_PATH%\translations\qt_*.qm" + working-directory: ${{runner.workspace}}/build + env: + DISTRIB_PATH: ${{runner.workspace}}/build/distrib/vnote + + - name: "Package Project: Copy OpenSSL on 5.15" + shell: cmd + if: startsWith(${{matrix.config.qt}}, '5.15') + run: | + set openssl_dir=openssl-utils.git\1.1.1j\Win_${{matrix.config.platform}} + copy %openssl_dir%\lib*.dll "%DISTRIB_PATH%\" + working-directory: ${{runner.workspace}}/build + env: + DISTRIB_PATH: ${{runner.workspace}}/build/distrib/vnote + + - name: Package Project 2 + shell: cmd + run: | 7z a vnote-win-${{matrix.config.platform}}-qt${{matrix.config.qt}}.zip "%DISTRIB_PATH%" copy vnote-win-${{matrix.config.platform}}-qt${{matrix.config.qt}}.zip vnote-win-${{matrix.config.platform}}-qt${{matrix.config.qt}}_v${{env.VNOTE_VER}}.zip working-directory: ${{runner.workspace}}/build @@ -95,6 +129,7 @@ jobs: DISTRIB_PATH: ${{runner.workspace}}/build/distrib/vnote - name: Package Installer + if: startsWith(${{matrix.config.qt}}, '6.') shell: cmd run: | copy "%GITHUB_WORKSPACE%\src\data\core\icons\vnote.ico" "%DISTRIB_PATH%\vnote.ico" @@ -115,6 +150,7 @@ jobs: DISTRIB_PATH: ${{runner.workspace}}/build/distrib/vnote - name: Archive Installer + if: startsWith(${{matrix.config.qt}}, '6.') uses: actions/upload-artifact@v2 with: name: VNote-win-${{matrix.config.platform}}-qt${{matrix.config.qt}}_v${{env.VNOTE_VER}}.msi From e0c1a18923ecc677a240e3136b311cfe5b6febe2 Mon Sep 17 00:00:00 2001 From: Le Tan Date: Sun, 8 Oct 2023 18:43:24 +0800 Subject: [PATCH 11/11] use jom --- .github/workflows/ci-win.yml | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci-win.yml b/.github/workflows/ci-win.yml index 63a2f1352f..092568d75e 100644 --- a/.github/workflows/ci-win.yml +++ b/.github/workflows/ci-win.yml @@ -75,18 +75,29 @@ jobs: - name: Clone OpenSSL on 5.15 shell: bash - if: startsWith(${{matrix.config.qt}}, '5.15') + if: ${{startsWith(matrix.config.qt, '5.15')}} run: | git clone https://github.com/tamlok/openssl-utils.git openssl-utils.git --depth=1 working-directory: ${{runner.workspace}}/build + - name: Download JOM + uses: suisei-cn/actions-download-file@v1 + with: + url: http://download.qt.io/official_releases/jom/jom.zip + target: ${{runner.temp}}\ + + - name: Unzip JOM + run: | + 7z x jom.zip -ojom + working-directory: ${{runner.temp}} + - name: Configure and Build Project shell: cmd run: | qmake --version call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" ${{matrix.config.platform}} qmake -r -spec win32-msvc CONFIG-=debug CONFIG+=release %GITHUB_WORKSPACE%\vnote.pro - nmake + ${{runner.temp}}\jom\jom working-directory: ${{runner.workspace}}/build - name: Package Project 1 @@ -111,7 +122,7 @@ jobs: - name: "Package Project: Copy OpenSSL on 5.15" shell: cmd - if: startsWith(${{matrix.config.qt}}, '5.15') + if: ${{startsWith(matrix.config.qt, '5.15')}} run: | set openssl_dir=openssl-utils.git\1.1.1j\Win_${{matrix.config.platform}} copy %openssl_dir%\lib*.dll "%DISTRIB_PATH%\" @@ -129,7 +140,7 @@ jobs: DISTRIB_PATH: ${{runner.workspace}}/build/distrib/vnote - name: Package Installer - if: startsWith(${{matrix.config.qt}}, '6.') + if: ${{startsWith(matrix.config.qt, '6.')}} shell: cmd run: | copy "%GITHUB_WORKSPACE%\src\data\core\icons\vnote.ico" "%DISTRIB_PATH%\vnote.ico" @@ -150,7 +161,7 @@ jobs: DISTRIB_PATH: ${{runner.workspace}}/build/distrib/vnote - name: Archive Installer - if: startsWith(${{matrix.config.qt}}, '6.') + if: ${{startsWith(matrix.config.qt, '6.')}} uses: actions/upload-artifact@v2 with: name: VNote-win-${{matrix.config.platform}}-qt${{matrix.config.qt}}_v${{env.VNOTE_VER}}.msi