From eaf4546c5aa73279b2c61ee5bf68e7cb915d7fda Mon Sep 17 00:00:00 2001
From: Le Tan <tamlokveer@gmail.com>
Date: Tue, 14 May 2024 23:06:26 +0800
Subject: [PATCH] fix

---
 src/CMakeLists.txt            | 2 +-
 src/CPackMacDeployQt.cmake.in | 2 +-
 src/Packaging.cmake           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 3b5de67489..073ca0c7f7 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -124,7 +124,7 @@ if (WIN32)
 elseif(APPLE)
     set(CMAKE_MACOSX_BUNDLE ON)
     set(CMAKE_MACOSX_RPATH ON)
-    install(TARGETS vnote BUNDLE DESTINATION . RUNTIME DESTINATION .)
+    install(TARGETS vnote BUNDLE DESTINATION ${CMAKE_INSTALL_DIR} RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
     set_target_properties(vnote
         PROPERTIES
         MACOSX_BUNDLE_BUNDLE_NAME "${PROJECT_NAME}"
diff --git a/src/CPackMacDeployQt.cmake.in b/src/CPackMacDeployQt.cmake.in
index 40656bf928..cd0c0fb8fb 100644
--- a/src/CPackMacDeployQt.cmake.in
+++ b/src/CPackMacDeployQt.cmake.in
@@ -1,4 +1,4 @@
-execute_process(COMMAND "${MACDEPLOYQT_EXECUTABLE}" ${CMAKE_BINARY_DIR}/${PROJECT_NAME}.app -dmg
+execute_process(COMMAND "${MACDEPLOYQT_EXECUTABLE}" ${CMAKE_CURRENT_BINARY_DIR}/vnote.app -dmg
     --always-overwirte
     WORKING_DIRECTORY ${CPACK_PACKAGE_DIRECTORY}
 )
diff --git a/src/Packaging.cmake b/src/Packaging.cmake
index 5fba3f18a5..37ae68df1f 100644
--- a/src/Packaging.cmake
+++ b/src/Packaging.cmake
@@ -131,7 +131,7 @@ elseif(APPLE)
         message(STATUS "Package generation - MacOS - DMG")
 
         list(APPEND CPACK_GENERATOR External)
-        set(CPACK_BUNDLE_NAME "vnote" )
+        set(CPACK_BUNDLE_NAME "${PROJECT_NAME}" )
         set(CPACK_BUNDLE_PLIST "${CMAKE_CURRENT_LIST_DIR}/data/core/Info.plist")
         set(CPACK_BUNDLE_ICON "${CMAKE_CURRENT_LIST_DIR}/data/core/icons/vnote.icns")
         set(CPACK_DMG_VOLUME_NAME "${PROJECT_NAME}")