Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix Mamba multistep #11071

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

tlrmchlsmth
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth commented Dec 10, 2024

Implements advance_step for PlaceholderAttention so that Mamba and other attention-free models function with multistep scheduling.

Fixes the following error in buildkite

ValueError: Multi-Step not supported for attention backend: NO_ATTENTION. Set VLLM_ATTENTION_BACKEND to a value from [‘FLASH_ATTN’, ‘ROCM_FLASH’, ‘FLASHINFER’].

Signed-off-by: Tyler Michael Smith <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! please test locally if it passes.

@tlrmchlsmth
Copy link
Collaborator Author

@youkaichao Of course I tested it locally! 😆

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 10, 2024
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) December 10, 2024 21:26
@tlrmchlsmth tlrmchlsmth merged commit 9a93973 into vllm-project:main Dec 11, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants