Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Bugfix] Always set enable_chunked_prefill = True for V1 #11061

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

WoosukKwon
Copy link
Collaborator

This PR fixes a bug in initializing the OpenAI server with V1: Currently, the server fails for some models with the error message: ValueError: max_num_batched_tokens (2048) is smaller than max_model_len (8192). This is because enable_chunked_prefill is not properly set.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@WoosukKwon WoosukKwon changed the title [V1] Always set enable_chunked_prefill = True for V1 [V1][Bugfix] Always set enable_chunked_prefill = True for V1 Dec 10, 2024
Signed-off-by: Woosuk Kwon <[email protected]>
vllm/engine/arg_utils.py Outdated Show resolved Hide resolved
vllm/engine/arg_utils.py Show resolved Hide resolved
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon WoosukKwon requested a review from comaniac December 10, 2024 18:24
@comaniac comaniac enabled auto-merge (squash) December 10, 2024 18:52
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 10, 2024
@WoosukKwon WoosukKwon disabled auto-merge December 10, 2024 22:41
@WoosukKwon WoosukKwon merged commit 134810b into main Dec 10, 2024
66 of 68 checks passed
@WoosukKwon WoosukKwon deleted the v1-chunked-prefill-flag branch December 10, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants