Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does vllm support pytorch/xla ? #3424

Closed
dinghaodhd opened this issue Mar 15, 2024 · 6 comments
Closed

Does vllm support pytorch/xla ? #3424

dinghaodhd opened this issue Mar 15, 2024 · 6 comments
Labels

Comments

@dinghaodhd
Copy link

Anything you want to discuss about vllm.

Hi,
We have adapt our harware to pytorch/xla, what should we do to run vllm via pytorch/xla?

@rkooo567
Copy link
Collaborator

I don't think it is working with pytorch/XLA now.

  1. The core attention algorithm that supports paged-attention is written in Cuda (and there are some other custom cuda kernels).
  2. def __init__(self, device: str = "auto") -> None:
    there are only neuron and cuda device options.

I think to make this work;

  • we should pass correct device settings. I don't know if xla requires additional changes other than providing a correct device, but if so, you need to change model_runner.py (preparing tensors) and general model path to make sure to use XLA config.
  • The core attention should use the kernel that works with paged attention.

@richardliaw
Copy link
Collaborator

There will be some exploration done from Google side I believe (cc @allenwang28)

@allenwang28
Copy link
Contributor

We are exploring TPU compatibility and support in #3620 through PyTorch/XLA.

but after this work, it should be clearer how to adapt PyTorch/XLA in vLLM for different hardware backends CC @WoosukKwon @miladm @shauheen

@yiakwy-xpu-ml-framework-team

Google has made its efforts in supportin TPU. We will make efforts to utilize the canonical IR optimizattion ,auto tuning, auto fusion, layout optimization form xla and stableHLO in GPU devices.

Copy link

github-actions bot commented Nov 7, 2024

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale label Nov 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants