Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orm: Option fk is zero-initialized instead of being set to none #23383

Closed
Le0Developer opened this issue Jan 5, 2025 · 0 comments · Fixed by #23400
Closed

orm: Option fk is zero-initialized instead of being set to none #23383

Le0Developer opened this issue Jan 5, 2025 · 0 comments · Fixed by #23400
Assignees
Labels
Bug This tag is applied to issues which reports bugs. ORM Bugs/feature requests, that are related to the V ORM. Status: Confirmed This bug has been confirmed to be valid by a contributor.

Comments

@Le0Developer
Copy link
Member

Le0Developer commented Jan 5, 2025

V doctor:

|V full version      |V 0.4.9 5b44b67.af1ef92
|:-------------------|:-------------------
|OS                  |macos, macOS, 15.2, 24C101
|Processor           |10 cpus, 64bit, little endian, Apple M4
|Memory              |0.68GB/16GB
|                    |
|V executable        |/Users/leodev/p/v/v/v
|V last modified time|2025-01-05 15:18:43
|                    |
|V home dir          |OK, value: /Users/leodev/p/v/v
|VMODULES            |OK, value: /Users/leodev/.vmodules
|VTMP                |OK, value: /tmp/v_501
|Current working dir |OK, value: /Users/leodev/p/v/fast2
|                    |
|Git version         |git version 2.47.0
|V git status        |weekly.2024.53-31-gaf1ef929 (1 commit(s) behind V master)
|.git/config present |true
|                    |
|cc version          |Apple clang version 16.0.0 (clang-1600.0.26.6)
|gcc version         |Apple clang version 16.0.0 (clang-1600.0.26.6)
|clang version       |Apple clang version 16.0.0 (clang-1600.0.26.6)
|tcc version         |tcc version 0.9.28rc 2024-02-05 HEAD@105d70f7 (AArch64 Darwin)
|tcc git status      |thirdparty-macos-arm64 713692d4
|emcc version        |N/A
|glibc version       |N/A

What did you do?
./v -g -o vdbg cmd/v && ./vdbg repro.v && repro

import db.sqlite

fn main() {
	db := sqlite.connect(':memory:')!

	sql db {
		create table Commit
		create table Measurement
	}!

	c := Commit { commit_hash: "hash" }
	sql db {
		insert c into Commit
	}!

	c2 := sql db {
		select from Commit
	}!
	println(c2)
	assert c2[0].v_self_default == none
}

@[table: 'commits']
struct Commit {
    commit_hash string @[primary]
    v_self_default         ?Measurement
}

@[table: 'measurements']
struct Measurement {
    id int @[primary; serial]
}

What did you see?

[Commit{
    commit_hash: 'hash'
    v_self_default: Option(Measurement{
        id: 0
    })
}]
repro.v:20: FAIL: fn main.main: assert c2[0].v_self_default == none
  left value: c2[0].v_self_default = Option(Measurement{
    id: 0
})
  right value: none = <none>
V panic: Assertion failed...
v hash: af1ef92
0   repro                               0x0000000102e95168 main__main + 4624
1   repro                               0x0000000102e955d4 main + 84
2   dyld                                0x000000019d4cc274 start + 2840

What did you expect to see?

Successful execution

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

Huly®: V_0.6-21814

@Le0Developer Le0Developer added the Bug This tag is applied to issues which reports bugs. label Jan 5, 2025
@felipensp felipensp self-assigned this Jan 7, 2025
@felipensp felipensp added Status: Confirmed This bug has been confirmed to be valid by a contributor. ORM Bugs/feature requests, that are related to the V ORM. labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. ORM Bugs/feature requests, that are related to the V ORM. Status: Confirmed This bug has been confirmed to be valid by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants