Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit how many runs NetAdaptiveTimestamp can take per frame #29

Closed
vladbat00 opened this issue Jun 14, 2021 · 0 comments · Fixed by #71
Closed

Limit how many runs NetAdaptiveTimestamp can take per frame #29

vladbat00 opened this issue Jun 14, 2021 · 0 comments · Fixed by #71
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vladbat00
Copy link
Owner

Currently, this run criteria can hang a browser tab if it has been frozen for some time (related: #10). This is not user friendly, so we should limit how many runs we allow per frame.

The run criteria should keep track of the time since it last returned ShouldRun::No and prevent returning ShouldRun::YesAndCheckAgain at some point in time. We want to target at least 20fps.

Bonus point: refactor the run criteria to be a simple system (Bevy cheatbook reference).
@vladbat00 vladbat00 added enhancement New feature or request good first issue Good for newcomers labels Jun 14, 2021
@vladbat00 vladbat00 changed the title Limit how many runs NetAdaptiveTimestemp can take per frame Limit how many runs NetAdaptiveTimestamp can take per frame Jan 20, 2022
@vladbat00 vladbat00 mentioned this issue Jan 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit how many runs NetAdaptiveTimestamp can take per frame vladbat00/muddle-run
1 participant
@vladbat00