Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge bench_lua into LuaJIT-test-cleanup? #4

Open
siddhesh opened this issue Mar 6, 2019 · 1 comment
Open

Merge bench_lua into LuaJIT-test-cleanup? #4

siddhesh opened this issue Mar 6, 2019 · 1 comment

Comments

@siddhesh
Copy link
Contributor

siddhesh commented Mar 6, 2019

The set of benchmarks in the LuaJIT-test-cleanup project are quite extensive but they lack a decent driver and timing methodology, which makes them kinda useless. This project has a good driver but not as many tests as LuaJIT-test-cleanup.

Given that LuaJIT-test-cleanup is eventually supposed to be integrated into LuaJIT proper, would you be opposed to me using your driver and related methodologies in the LuaJIT-test-cleanup and eventually in the LuaJIT project? I'll obviously give you full credit for both and retain licenses, etc.

I understand that this may never actually make it into the official repo but I'd like to give it a shot anyway, in the interest of making some forward progress in the project.

@vkrasnov
Copy link
Owner

vkrasnov commented Mar 6, 2019

Hi, thank you for the PR, I will go over it in a couple of days.
You are more than welcome to use it as you see fit.
I might actually add LuaJIT-test-cleanup as a dependency too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants