Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency ot-json1 #36

Closed
curran opened this issue Mar 6, 2023 · 0 comments
Closed

Missing dependency ot-json1 #36

curran opened this issue Mar 6, 2023 · 0 comments

Comments

@curran
Copy link
Contributor

curran commented Mar 6, 2023

The package ot-json1 is imported, but not listed as a dependency.

Furthermore, this library should not have a direct dependency on that package, but rather should allow the consumer to pass in the OT library, such as ot-json1-presence which supports presence.

Error from consuming project: vizhub-core/vzcode#16

[vite]: Rollup failed to resolve import "ot-json1" from "/home/curran/repos/vzcode/node_modules/codemirror-ot/src/translation.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
error during build:
Error: [vite]: Rollup failed to resolve import "ot-json1" from "/home/curran/repos/vzcode/node_modules/codemirror-ot/src/translation.js".
This is most likely unintended because it can break your application at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant