From edec02c14e923c3c1390ee70137d617dc5476bfe Mon Sep 17 00:00:00 2001 From: Alexander Kaufmann Date: Thu, 19 Dec 2024 09:11:43 +0100 Subject: [PATCH 1/2] chore: invoke SonarQube via GitHub action --- .github/workflows/sonar-qube.yml | 40 ++++++++++++++++++++++++++++++++ sonar-project.properties | 8 +++++++ 2 files changed, 48 insertions(+) create mode 100644 .github/workflows/sonar-qube.yml create mode 100644 sonar-project.properties diff --git a/.github/workflows/sonar-qube.yml b/.github/workflows/sonar-qube.yml new file mode 100644 index 00000000..1fb0ea7f --- /dev/null +++ b/.github/workflows/sonar-qube.yml @@ -0,0 +1,40 @@ +name: SonarCloud Code Analysis + +on: + pull_request: + types: + - opened + - synchronize + - reopened + push: + branches: + - main + - next + +jobs: + sonarqube: + name: SonarQube + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - uses: pnpm/action-setup@v2 + with: + version: 8 + + - name: Use Node.js 18.x + uses: actions/setup-node@v3 + with: + node-version: 18 + registry-url: "https://registry.npmjs.org" + cache: "pnpm" # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies + + - run: pnpm install --frozen-lockfile + + - name: SonarQube Scan + uses: SonarSource/sonarqube-scan-action@v4 + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} diff --git a/sonar-project.properties b/sonar-project.properties new file mode 100644 index 00000000..1ed4c83c --- /dev/null +++ b/sonar-project.properties @@ -0,0 +1,8 @@ +sonar.projectKey=vivid-planet_comet-brevo-module +sonar.organization=vivid-planet +sonar.sources=demo/,packages/ +sonar.tests=packages/ +sonar.test.inclusions=packages/**/__tests__/**,packages/**/*.spec.ts +sonar.exclusions=packages/**/__tests__/**,packages/**/*.spec.ts +sonar.cpd.exclusions=packages/**/__tests__/**,packages/**/*.spec.ts +sonar.typescript.tsconfigPaths=demo/*/tsconfig.json,packages/*/tsconfig.json From db6121a3b1f1db5ecac568a0e78c6bf3037e2a12 Mon Sep 17 00:00:00 2001 From: Thomas Dax Date: Fri, 20 Dec 2024 08:28:47 +0100 Subject: [PATCH 2/2] Remove mjml peer dependency from demo campaign (#250) --- demo/campaign/package.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/demo/campaign/package.json b/demo/campaign/package.json index c77e25ae..b9992e4d 100644 --- a/demo/campaign/package.json +++ b/demo/campaign/package.json @@ -72,8 +72,5 @@ "rimraf": "^3.0.0", "tsconfig-paths": "^3.0.0", "typescript": "^4.0.0" - }, - "peerDependencies": { - "mjml": "^4.7.0" } }