go mod tidy doesn't work

[alias-rahil]

Output go mod tidy:

go: downloading github.com/digitalocean/godo v1.65.0
go: downloading github.com/kanisterio/kanister v0.0.0-20210903215800-f8e63bf1364d
go: downloading github.com/google/go-querystring v1.0.0
go: downloading github.com/jpillora/backoff v1.0.0
go: finding module for package k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset
github.com/viveksinghggits/kluster/pkg/client/informers/internalversion imports
	k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset: module k8s.io/kubernetes@latest found (v1.23.4), but does not contain package k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset

Output go version:

go version go1.17.7 linux/amd64

Output uname -a:

Linux alias-rahil 5.15.25-1-lts #1 SMP Wed, 23 Feb 2022 12:02:12 +0000 x86_64 GNU/Linux

[viveksinghggits]

Hi @alias-rahil,
thanks for reporting this, can you confirm if go build works and creates the binary correctly.

[viveksinghggits]

Meanwhile I will look into the issue that you reported.

[alias-rahil]

Yes, go build works correctly

[alias-rahil]

I was able to determine why the error was occurring. You had accidentally set the metadata type for KlusterList as metav1.ObjectMeta instead of metav1.ListMeta and then you ran the code-generator script.

While you fixed the error at a later stage, the dirty output of the code-generator was still present in the client directory. I will be creating a PR with the fix.

[Kavinraja-G]

@viveksinghggits Any idea on the above issue ?

@alias-rahil Looks like the k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset package is not available in the latest versions.

[viveksinghggits]

Hi @Kavinraja-G,
@alias-rahil was able to figure out why its happening. I also think that he is planning to to push the fix soon. thats being discussed as part of linked PR.

[viveksinghggits]

@alias-rahil since we decided not to merge the PR, can you please update the steps here that you followed to make the go mod tidy work locally.

[alias-rahil]

Sure, These were the files that were accidentally created but are not needed. Removing these files fixes the issue:

• manifests/viveksingh.dev_klusterlists.yaml
• pkg/client/informers/internalversion/factory.go
• pkg/client/informers/internalversion/generic.go
• pkg/client/informers/internalversion/internalinterfaces/factory_interfaces.go
• pkg/client/informers/internalversion/v1alpha1/interface.go
• pkg/client/informers/internalversion/v1alpha1/internalversion/interface.go
• pkg/client/informers/internalversion/v1alpha1/internalversion/kluster.go
• pkg/client/listers/v1alpha1/internalversion/expansion_generated.go
• pkg/client/listers/v1alpha1/internalversion/kluster.go

You should be able to run go mod tidy successfully now :)

[Kavinraja-G]

What happens to the listers and informers that we use in the controller? If we remove these files @alias-rahil?

Looks like they are being used https://github.com/viveksinghggits/kluster/blob/master/pkg/controller/kluster.go#L12? (correct me if I'm wrong - @viveksinghggits)

[alias-rahil]

@Kavinraja-G

kluster/pkg/controller/kluster.go

Line 12 in f0eb888

klister "github.com/viveksinghggits/kluster/pkg/client/listers/viveksingh.dev/v1alpha1"

we aren't deleting this file

We are only deleting the listers from under pkg/client/listers/v1alpha1/internalversion.

[viveksinghggits]

Re-opening so that it people can refer this issue, if they get into the same problem.