-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updating all dependencies #123
Conversation
phorward
commented
Jan 8, 2024
•
edited
Loading
edited
- Update viur-core 3.5.12
- Update viur-cli 1.1.2
- Update viur-admin 4.0.24
- Update app.yaml
- Update project.json
- Update README.md
- Update tox.ini
- Update .gitignore
- Cleaned-up clean-base.py
- Update viur-core 3.5.10 - Update viur-cli 1.1.1 - Update viur-admin 4.0.22 - Update app.yaml - Update project.json - Update README.md - Cleaned-up clean-base.py
deploy/app.yaml
Outdated
@@ -7,7 +7,7 @@ instance_class: F1 | |||
default_expiration: "30s" | |||
|
|||
# (2) To get more memory and concurrent requests, a separate gunicorn is run. | |||
entrypoint: gunicorn -b :$PORT -w 1 --threads 2 --disable-redirect-access-to-syslog main:app | |||
entrypoint: gunicorn -b :$PORT -w 1 --threads 2 --disable-redirect-access-to-syslog --timeout 60 main:app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phorward Can you explain the reason for this timeout? Doesn't this now lead to tasks having a timeout of 60 seconds instead of 10 minutes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sure. My laptop is sometimes a little slow. I got an annoying timeout. This helps, and is more equal to GAE (default timeout is 30 sec).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I'm not sure if this influences the time behavior for tasks. We have to find out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In viur-framework/viur-app_server#6 I added the timeout argument to this gunicorn launcher. Then it will use the default value of 60 seconds of the CLI (https://github.com/viur-framework/viur-app_server/blob/3d382cc00cc174586aa532164a0f0583fc5d4d9d/src/app_server/__init__.py#L325) anyway. And if you want you can increase this by providing a higher value (viur run develop --timeout 360
)
Maybe this solves your issues. But, … @ArneGudermann has to release this change :D