Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating all dependencies #123

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

phorward
Copy link
Member

@phorward phorward commented Jan 8, 2024

  • Update viur-core 3.5.12
  • Update viur-cli 1.1.2
  • Update viur-admin 4.0.24
  • Update app.yaml
  • Update project.json
  • Update README.md
  • Update tox.ini
  • Update .gitignore
  • Cleaned-up clean-base.py

- Update viur-core 3.5.10
- Update viur-cli 1.1.1
- Update viur-admin 4.0.22
- Update app.yaml
- Update project.json
- Update README.md
- Cleaned-up clean-base.py
@sveneberth sveneberth added dependencies Pull requests that update a dependency file Priority: High After critical issues are fixed, these should be dealt with before any further issues. labels Jan 9, 2024
deploy/app.yaml Outdated
@@ -7,7 +7,7 @@ instance_class: F1
default_expiration: "30s"

# (2) To get more memory and concurrent requests, a separate gunicorn is run.
entrypoint: gunicorn -b :$PORT -w 1 --threads 2 --disable-redirect-access-to-syslog main:app
entrypoint: gunicorn -b :$PORT -w 1 --threads 2 --disable-redirect-access-to-syslog --timeout 60 main:app
Copy link
Member

@sveneberth sveneberth Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phorward Can you explain the reason for this timeout? Doesn't this now lead to tasks having a timeout of 60 seconds instead of 10 minutes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure. My laptop is sometimes a little slow. I got an annoying timeout. This helps, and is more equal to GAE (default timeout is 30 sec).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not sure if this influences the time behavior for tasks. We have to find out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In viur-framework/viur-app_server#6 I added the timeout argument to this gunicorn launcher. Then it will use the default value of 60 seconds of the CLI (https://github.com/viur-framework/viur-app_server/blob/3d382cc00cc174586aa532164a0f0583fc5d4d9d/src/app_server/__init__.py#L325) anyway. And if you want you can increase this by providing a higher value (viur run develop --timeout 360)
Maybe this solves your issues. But, … @ArneGudermann has to release this change :D

Pipfile Outdated Show resolved Hide resolved
@sveneberth sveneberth added the waiting-for-changes Waiting for changes/rework from the author label Jan 19, 2024
deploy/app.yaml Outdated Show resolved Hide resolved
@sveneberth sveneberth removed the waiting-for-changes Waiting for changes/rework from the author label Jan 30, 2024
@sveneberth sveneberth merged commit 8854ecd into viur-framework:main Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants