Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining Eclipse UI dependencies #119

Open
larsk21 opened this issue Dec 10, 2024 · 2 comments
Open

Remove remaining Eclipse UI dependencies #119

larsk21 opened this issue Dec 10, 2024 · 2 comments

Comments

@larsk21
Copy link
Contributor

larsk21 commented Dec 10, 2024

While we removed most Eclipse UI dependencies when transitioning to our new build system, there are still parts left, e.g., in tools/vitruv/change/interaction/dialogs.

@bjthehun
Copy link

If no one else would mind, I will be working on this issue.

@bjthehun
Copy link

I have identified three explicit Eclipse UI dependencies in the interaction module:

  1. org.eclipse.platform:org.eclipse.jface
  2. org.eclipse.platform:org.eclipse.ui.workbench
  3. org.eclipse.platform:org.eclipse.swt

These dependencies are required to implement and present different dialogs for user input in Eclipse (tools.virtuv.change.interaction.impl.DialogInteractionResultProviderImpl, all classes in tools.vitruv.change.interaction.dialogs). However, only the PlatformUI dependency in DialogInteractionResultProviderImpl is strictly Eclipse-specific (to get a display to show dialogs in).

My question is: Should we keep the dialogs, and if yes, should we use SWT or something else (e.g. Swing/AWT)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants