Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.5.9 pre-release] Continuous run stop working if one of the imported file is updated #318

Open
6 tasks done
MangelMaxime opened this issue Mar 22, 2024 · 1 comment
Open
6 tasks done

Comments

@MangelMaxime
Copy link

Describe the bug

When updated the code of an imported file, continuous mode doesn't trigger even if I re-save the test file himself.

Stopping / Start continuous doesn't work, I need to re-start VSCode for it to work again.

Reproduction

  1. Open vitest-dev/vscode/samples/basic folder
  2. Click Start continunous mode (global)
  3. Select the run config
  4. Open add.test.js and force save the file
  5. Tests should run
  6. Go to add.ts and make a change to the file + save
  7. Tests are not running, when on the non pre-release version they re-run
  8. Open add.test.js and force save the file
  9. Nothing happens (tests should be re-run)

Only way to make Continous mode working again is by reloading VSCode.

CleanShot.2024-03-22.at.18.37.37.mp4

System Info

System:
    OS: macOS 14.4
    CPU: (10) arm64 Apple M1 Max
    Memory: 77.20 MB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.9.0 - ~/Library/Caches/fnm_multishells/4208_1711128498880/bin/node
    Yarn: 1.22.22 - ~/Library/Caches/fnm_multishells/4208_1711128498880/bin/yarn
    npm: 10.1.0 - ~/Library/Caches/fnm_multishells/4208_1711128498880/bin/npm
    pnpm: 8.13.1 - ~/Library/Caches/fnm_multishells/4208_1711128498880/bin/pnpm
    bun: 1.0.18 - ~/.bun/bin/bun
  IDEs:
    VSCode: 1.87.2 - /usr/local/bin/code
    Vim: 9.0 - /usr/bin/vim
    Xcode: /undefined - /usr/bin/xcodebuild
  Browsers:
    Chrome: 123.0.6312.59
    Safari: 17.4
  npmPackages:
    vite: ^2.8.6 => 2.9.17 
    vitest: ^1.4.0 => 1.4.0

Used Package Manager

npm

Validations

@sheremet-va sheremet-va added p4-important Violate documented behavior or significantly improves performance (priority) and removed pending triage labels Mar 22, 2024
@sheremet-va
Copy link
Member

This should be fixed in 0.5.13. I am adding a label here to add a test to catch regression in the future.

@sheremet-va sheremet-va added needs test and removed p4-important Violate documented behavior or significantly improves performance (priority) labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants