Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated KiSAO OBO and added parsing for KiSAO_694 #1393

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Updated KiSAO OBO and added parsing for KiSAO_694 #1393

merged 2 commits into from
Nov 27, 2024

Conversation

CodeByDrescher
Copy link
Contributor

No description provided.

jcschaff
jcschaff approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style wise - the assert dealing with a misconfiguration should be replace with some other exception. asserts are best used in test code.

Approved anyway.

vcell-core/src/main/java/cbit/util/kisao/KisaoTermParser.java Outdated Show resolved Hide resolved
@CodeByDrescher CodeByDrescher merged commit 7578b6a into master Nov 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcschaff jcschaff jcschaff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeByDrescher @jcschaff