Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimulationMessaging uses antipattern-version of Singleton #30

Open
CodeByDrescher opened this issue Jan 26, 2024 · 0 comments
Open

SimulationMessaging uses antipattern-version of Singleton #30

CodeByDrescher opened this issue Jan 26, 2024 · 0 comments

Comments

@CodeByDrescher
Copy link
Contributor

SimulationMessaging implements both a create method, and a getInstVar method, where getInstVar is quietly vulnerable to a nullptr SEGFAULT if create isn't called.

Per proper Singleton design, create should be removed, and it's logic transfered to getInstVar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Queued
Development

No branches or pull requests

1 participant