diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index fcae4d3..f37b5cd 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -17,6 +17,8 @@ jobs: python-version: [ "3.12" ] steps: - uses: actions/checkout@v4 + with: + fetch-depth: 0 - name: "pip: Python ${{ matrix.python-version }} coverage" uses: actions/setup-python@v5 with: diff --git a/codecov.yml b/codecov.yml index 0ceb3f5..a48c11f 100644 --- a/codecov.yml +++ b/codecov.yml @@ -6,4 +6,4 @@ coverage: threshold: 1% # leeway patch: default: - target: 80% + target: 75% diff --git a/src/Error.cpp b/src/Error.cpp index 9b32838..2c3ea6a 100644 --- a/src/Error.cpp +++ b/src/Error.cpp @@ -1,6 +1,8 @@ #include "Error.h" #include +namespace py = pybind11; + const char* no::NotImplementedError::what() const noexcept { return m_msg.c_str(); @@ -16,6 +18,6 @@ void no::exception_translator(std::exception_ptr p) } catch (const no::NotImplementedError& e) { - PyErr_SetString(PyExc_NotImplementedError, e.what()); + py::set_error(PyExc_NotImplementedError, e.what()); } }