From 7f2e461e9b6bf01f8e6030ac8ebdb3b7f8773b5e Mon Sep 17 00:00:00 2001
From: Ville Penttinen <villem.penttinen@gmail.com>
Date: Mon, 4 Dec 2023 04:33:39 +0200
Subject: [PATCH] Add Directory.Build.props and global.json

---
 Directory.Build.props                         | 78 +++++++++++++++++++
 global.json                                   |  6 ++
 src/Visp.Cli/Visp.Cli.fsproj                  |  2 -
 src/Visp.Common/Visp.Common.csproj            |  2 -
 src/Visp.Compiler/Visp.Compiler.fsproj        |  2 -
 .../Visp.LanguageServer.fsproj                |  1 -
 .../Visp.Runtime.Library.fsproj               |  4 +-
 .../Visp.Compiler.UnitTests.fsproj            |  3 +-
 8 files changed, 87 insertions(+), 11 deletions(-)
 create mode 100644 Directory.Build.props
 create mode 100644 global.json

diff --git a/Directory.Build.props b/Directory.Build.props
new file mode 100644
index 0000000..8a6a1d5
--- /dev/null
+++ b/Directory.Build.props
@@ -0,0 +1,78 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+    <PropertyGroup>
+        <TargetFramework>net8.0</TargetFramework>
+        <Features>strict</Features>
+        <SatelliteResourceLanguages>en</SatelliteResourceLanguages>
+        <InvariantGlobalization>true</InvariantGlobalization>
+    </PropertyGroup>
+
+    <!-- Build -->
+    <PropertyGroup>
+        <TreatWarningsAsErrors Condition="'$(Configuration)' == 'Release'">true</TreatWarningsAsErrors>
+         <!-- Enable linter -->
+        <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+
+        <WarnOnPackingNonPackableProject>true</WarnOnPackingNonPackableProject>
+    </PropertyGroup>
+
+    <!-- Packaging -->
+    <PropertyGroup>
+        <!-- Enable packaging on a per-project basis. -->
+        <IsPackable>false</IsPackable>
+        <IsPublishable>false</IsPublishable>
+
+        <Authors>Ville Penttinen</Authors>
+        <Copyright>Copyright © 2023 Ville Penttinen</Copyright>
+        <PackageProjectUrl>https://github.com/vipentti/visp-fs</PackageProjectUrl>
+        <RepositoryType>git</RepositoryType>
+        <RepositoryUrl>https://github.com/vipentti/visp-fs</RepositoryUrl>
+
+        <!-- Optional: Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
+        <PublishRepositoryUrl>true</PublishRepositoryUrl>
+
+        <!-- Optional: Embed source files that are not tracked by the source control manager in the PDB -->
+        <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    </PropertyGroup>
+
+    <PropertyGroup>
+        <UseReproducibleBuild Condition="'$(UseReproducibleBuild)'==''">false</UseReproducibleBuild>
+        <PackableProjects>Visp.Runtime.Library</PackableProjects>
+    </PropertyGroup>
+
+    <Choose>
+        <When Condition="$(PackableProjects.Contains('$(MSBuildProjectName)'))">
+
+            <PropertyGroup>
+                <PackageReadmeFile>README.md</PackageReadmeFile>
+                <PackageLicenseFile>LICENSE.md</PackageLicenseFile>
+                <PackageIcon>icon.png</PackageIcon>
+
+                <EnablePackageValidation>true</EnablePackageValidation>
+
+                <!-- Recommended: Embed symbols containing Source Link in the main file (exe/dll) -->
+                <DebugType>embedded</DebugType>
+
+                <!-- Embed source files that are not tracked by the source control manager in the PDB -->
+                <EmbedUntrackedSources>true</EmbedUntrackedSources>
+
+                <GenerateDocumentationFile>True</GenerateDocumentationFile>
+                <!-- If all members are not documented, you can disable the compiler warnings -->
+                <NoWarn>$(NoWarn);CS1591</NoWarn>
+            </PropertyGroup>
+
+            <ItemGroup>
+                <None Include="$(MSBuildThisFileDirectory)LICENSE.md" Pack="true" PackagePath="" Visible="false" />
+                <None Include="$(MSBuildThisFileDirectory)icon.png" Pack="true" PackagePath="" Visible="false" />
+                <None Include="$(MSBuildThisFileDirectory)README.md" Pack="true" PackagePath="\" />
+            </ItemGroup>
+
+            <ItemGroup Condition="'$(UseReproducibleBuild)' == 'true'">
+                <PackageReference Include="DotNet.ReproducibleBuilds" Version="1.1.1">
+                    <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+                    <PrivateAssets>all</PrivateAssets>
+                </PackageReference>
+            </ItemGroup>
+        </When>
+    </Choose>
+</Project>
diff --git a/global.json b/global.json
new file mode 100644
index 0000000..c19a2e0
--- /dev/null
+++ b/global.json
@@ -0,0 +1,6 @@
+{
+  "sdk": {
+    "version": "8.0.100",
+    "rollForward": "latestMinor"
+  }
+}
diff --git a/src/Visp.Cli/Visp.Cli.fsproj b/src/Visp.Cli/Visp.Cli.fsproj
index 7d89fc7..6f0af5e 100644
--- a/src/Visp.Cli/Visp.Cli.fsproj
+++ b/src/Visp.Cli/Visp.Cli.fsproj
@@ -2,8 +2,6 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net8.0</TargetFramework>
-    <InvariantGlobalization>true</InvariantGlobalization>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/Visp.Common/Visp.Common.csproj b/src/Visp.Common/Visp.Common.csproj
index e640d6a..48595ca 100644
--- a/src/Visp.Common/Visp.Common.csproj
+++ b/src/Visp.Common/Visp.Common.csproj
@@ -1,10 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <InvariantGlobalization>true</InvariantGlobalization>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/Visp.Compiler/Visp.Compiler.fsproj b/src/Visp.Compiler/Visp.Compiler.fsproj
index e584e7a..c6524e0 100644
--- a/src/Visp.Compiler/Visp.Compiler.fsproj
+++ b/src/Visp.Compiler/Visp.Compiler.fsproj
@@ -1,8 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <InvariantGlobalization>true</InvariantGlobalization>
     <FsYaccOutputFolder>Syntax\\FsLexYaccOutput\\</FsYaccOutputFolder>
     <FsLexOutputFolder>Syntax\\FsLexYaccOutput\\</FsLexOutputFolder>
   </PropertyGroup>
diff --git a/src/Visp.LanguageServer/Visp.LanguageServer.fsproj b/src/Visp.LanguageServer/Visp.LanguageServer.fsproj
index 86ffbf1..438819b 100644
--- a/src/Visp.LanguageServer/Visp.LanguageServer.fsproj
+++ b/src/Visp.LanguageServer/Visp.LanguageServer.fsproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net8.0</TargetFramework>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/Visp.Runtime.Library/Visp.Runtime.Library.fsproj b/src/Visp.Runtime.Library/Visp.Runtime.Library.fsproj
index cc2cdb2..c106d37 100644
--- a/src/Visp.Runtime.Library/Visp.Runtime.Library.fsproj
+++ b/src/Visp.Runtime.Library/Visp.Runtime.Library.fsproj
@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <IsPackable>true</IsPackable>
+    <IsPublishable>true</IsPublishable>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <InvariantGlobalization>true</InvariantGlobalization>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="Common.fs" />
diff --git a/tests/Visp.Compiler.UnitTests/Visp.Compiler.UnitTests.fsproj b/tests/Visp.Compiler.UnitTests/Visp.Compiler.UnitTests.fsproj
index ec9545c..a034398 100644
--- a/tests/Visp.Compiler.UnitTests/Visp.Compiler.UnitTests.fsproj
+++ b/tests/Visp.Compiler.UnitTests/Visp.Compiler.UnitTests.fsproj
@@ -1,6 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
     <IsPackable>false</IsPackable>
     <GenerateProgramFile>false</GenerateProgramFile>
     <IsTestProject>true</IsTestProject>
@@ -18,7 +17,7 @@
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
-    <PackageReference Include="Verify.Xunit" Version="22.6.0" />
+    <PackageReference Include="Verify.Xunit" Version="22.6.1" />
     <PackageReference Include="xunit" Version="2.6.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.5.4">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>