Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating JTabbedPane #30

Closed
srcarter3 opened this issue Apr 12, 2019 · 17 comments
Closed

Updating JTabbedPane #30

srcarter3 opened this issue Apr 12, 2019 · 17 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@srcarter3
Copy link

I was wondering if the look and feel could update the look of a JTabbedPane? I feel like it still looks like it did previously.
I have attached a screenshot of what it looks like currently with the material library, and a mock up of what we would like to achieve. (Some of the components are in different places, but please just focus on the tab appearances, thank you).
Do you think it's possible? Do you like the look?
Screenshot-12
Screenshot-11

@vincenzopalazzo
Copy link
Owner

Hi @srcarter3,

Yes this look is wonderful, I have to think about how to do it, it will take some time

@vincenzopalazzo vincenzopalazzo self-assigned this Apr 12, 2019
@vincenzopalazzo vincenzopalazzo added the enhancement New feature or request label Apr 12, 2019
@zanderson9
Copy link
Collaborator

@srcarter3, good comment, thanks for bringing this up with Vincent.

@vincenzopalazzo
Copy link
Owner

This is the only version for tesh,

Do you like this effect?

@srcarter3
Copy link
Author

Very cool. Could the spacing be a little more? Can the tabs be centered in the tabbed pane (instead of left-aligned). Ex. if you have a very wide panel, can the tabs be centered? (like the screenshot above?)

@vincenzopalazzo
Copy link
Owner

Just to understand if I understood correctly, the spacing along the x axis is true?

@srcarter3
Copy link
Author

Yes, that's what I'm referring to.

@vincenzopalazzo
Copy link
Owner

Now is ok? :)
Selection_049

@srcarter3
Copy link
Author

Hmmm. I'm not sure I can tell the difference.
I'm mostly referring to the the tab alignment within the entire panel.
See the screenshots below.
Screenshot-12
Screenshot-11

@vincenzopalazzo
Copy link
Owner

@srcarter3, For the position it takes a little more time, sorry

@srcarter3
Copy link
Author

That's totally ok. Don't feel like I'm rushing you.

@vincenzopalazzo
Copy link
Owner

Ok now I understand, you want there to be more space between one Tab and another, right? on this we will work and I will try to reproduce your mock because it is cool, now I make a commit to make some small changes, but above all this fix has to be revised from the point of view of the composting of the change state of the component

@srcarter3
Copy link
Author

Yes, more space between each tab.
And, all tabs centered, not left-aligned.

Okay, that sounds good! Thank you.

@vincenzopalazzo vincenzopalazzo added the help wanted Extra attention is needed label Apr 26, 2019
This was referenced May 10, 2019
@vincenzopalazzo
Copy link
Owner

Hi @srcarter3 @zanderson9 ,

I added this change

This is the reference for the changes
I attend your feedback, thanks so much

@zanderson9
Copy link
Collaborator

Hello @vincenzopalazzo,
With the newest release of the library which implements centered tabs, we started to notice a shift-left of the tabs. Specifically, the shift to the left is noticeable when we add tabs, or "Dock", tabs to a TabbedPane.
I am attaching the document where I show various scenarios of adding tabs dynamically to a tabbed pane and how they shift. The document also shows, for comparison, how docking same tabs worked in pure swing version of JMARS.
Is this something that can be corrected now?
If not, we would need to revert to the pre-centered version of the tabbed pane. Let us know, please.
TABS-Issue.pdf

@vincenzopalazzo
Copy link
Owner

Hi @zanderson9,

I'm sorry if my commit not works correctly but the component JTabbledPane is not thought of sun developer for a different position to left or right, I have created an adapter for the code OpenJDK for apport the fix in the layout.

For a moment I do not have some time for good work, so In the weekend I going to disable the adapter and the look restore the original layout.

Sorry for this problem.

I have a question for you, can you open an issue with the screenshot the tabbed pane component material so I add the new label if any person want to collaborate with us that adding a new support component. Thanks

@zanderson9
Copy link
Collaborator

Vincent, I posted this request in a New Issue, as per your preference.

@vincenzopalazzo
Copy link
Owner

Hi @srcarter3 thanks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants