Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify _black.py to handle code cell "??" and "?" #17

Merged

Conversation

ericmjl
Copy link
Contributor

@ericmjl ericmjl commented Nov 15, 2019

@vinayak-mehta here’s the PR!

If merged, this will close #11.

I have not yet looked into tests; do you have a preferred system for testing here?

The "??" and "?" syntax is used in Jupyter
to show source code as part of the code cell output.
@vinayak-mehta
Copy link
Owner

No testing framework in place right now but would sure love to work on adding something in that regard.

Will merge your PR today!

@vinayak-mehta
Copy link
Owner

Thanks for raising one :)

@vinayak-mehta vinayak-mehta merged commit d76973c into vinayak-mehta:master Nov 15, 2019
@vinayak-mehta
Copy link
Owner

Thanks for the contribution! I didn't know about ?? :)

@vinayak-mehta
Copy link
Owner

Just saw that ?? also works if it is put at the end of the function. But right now we're only checking if the code begins with ??.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot parse ?? when specified at the end of function name
2 participants